chrome/browser/extensions/activity_log/activity_log.h - Issue 18660004: Extension activity log database refactoring (step 1)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log.h

Issue 18660004: Extension activity log database refactoring (step 1) (Closed) Base URL: http://git.chromium.org/chromium/src.git@incognito-tests

Patch Set: Delegate renaming and comment cleanup Created 7 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/activity_log/activity_log.h

diff --git a/chrome/browser/extensions/activity_log/activity_log.h b/chrome/browser/extensions/activity_log/activity_log.h

index cef16ad63f9d6c839acc3f741548312f624c4abb..25691bf4b2eb331352e486e64fa7d4c12f88df8f 100644

--- a/chrome/browser/extensions/activity_log/activity_log.h

+++ b/chrome/browser/extensions/activity_log/activity_log.h

@@ -185,7 +185,10 @@ class ActivityLog : public BrowserContextKeyedService,

scoped_refptr<ObserverList> observers_;

// The policy object takes care of data summarization, compression, and

- // logging

+ // logging. The policy object is owned by the ActivityLog, but this cannot

+ // be a scoped_ptr since some cleanup work must happen on the database

+ // thread. Calling policy_->Close() will free the object; see the comments

+ // on the ActivityDatabase class for full details.

extensions::ActivityLogPolicy* policy_;

// TODO(dbabic,felt) change this into a list of policy types later.