Extension activity log database refactoring (step 1)

chrome/browser/extensions/activity_log/activity_database_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/run_loop.h"
@@ skipping 21 matching lines @@
 #include "chrome/browser/chromeos/login/user_manager.h"
 #include "chrome/browser/chromeos/settings/cros_settings.h"
 #include "chrome/browser/chromeos/settings/device_settings_service.h"
 #include "chromeos/chromeos_switches.h"
 #endif
 
 using content::BrowserThread;
 
 namespace extensions {
 
+// A dummy implementation of ActivityDatabase::Delegate, sufficient for
+// the unit tests.
+class ActivityDatabaseTestPolicy : public ActivityDatabase::Delegate {
+ public:
+  ActivityDatabaseTestPolicy() {};
+
+ protected:
+  virtual bool OnDatabaseInit(sql::Connection* db) OVERRIDE {
+    if (!DOMAction::InitializeTable(db)) return false;
+    if (!APIAction::InitializeTable(db)) return false;
+    if (!BlockedAction::InitializeTable(db)) return false;
+    return true;
+  }
+
+  // Called by ActivityDatabase just before the ActivityDatabase object is
+  // deleted.  The database will make no further callbacks after invoking this
+  // method, so it is an appropriate time for the policy to delete itself.
+  virtual void OnDatabaseClose() OVERRIDE {
+    delete this;
+  }
+};
+
 class ActivityDatabaseTest : public ChromeRenderViewHostTestHarness {
  protected:
   virtual void SetUp() OVERRIDE {
     ChromeRenderViewHostTestHarness::SetUp();
 #if defined OS_CHROMEOS
     test_user_manager_.reset(new chromeos::ScopedTestUserManager());
 #endif
     CommandLine command_line(CommandLine::NO_PROGRAM);
     CommandLine::ForCurrentProcess()->AppendSwitch(
         switches::kEnableExtensionActivityLogTesting);
   }
 
   virtual void TearDown() OVERRIDE {
 #if defined OS_CHROMEOS
     test_user_manager_.reset();
 #endif
     ChromeRenderViewHostTestHarness::TearDown();
   }
 
+  // Creates a test database and initializes the table schema.
+  ActivityDatabase* OpenDatabase(const base::FilePath& db_file) const {
+    ActivityDatabase* activity_db =
+        new ActivityDatabase(new ActivityDatabaseTestPolicy());
+    activity_db->Init(db_file);
+    CHECK(activity_db->is_db_valid());
+    return activity_db;
+  }
+
  private:
 #if defined OS_CHROMEOS
   chromeos::ScopedStubCrosEnabler stub_cros_enabler_;
   chromeos::ScopedTestDeviceSettingsService test_device_settings_service_;
   chromeos::ScopedTestCrosSettings test_cros_settings_;
   scoped_ptr<chromeos::ScopedTestUserManager> test_user_manager_;
 #endif
 
 };
 
 
 // Check that the database is initialized properly.
 TEST_F(ActivityDatabaseTest, Init) {
   base::ScopedTempDir temp_dir;
   base::FilePath db_file;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   db_file = temp_dir.path().AppendASCII("ActivityInit.db");
   base::Delete(db_file, false);
 
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
-  ASSERT_TRUE(activity_db->is_db_valid());
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   activity_db->Close();
 
   sql::Connection db;
   ASSERT_TRUE(db.Open(db_file));
   ASSERT_TRUE(db.DoesTableExist(DOMAction::kTableName));
   ASSERT_TRUE(db.DoesTableExist(APIAction::kTableName));
   ASSERT_TRUE(db.DoesTableExist(BlockedAction::kTableName));
   db.Close();
 }
 
 // Check that API actions are recorded in the db.
 TEST_F(ActivityDatabaseTest, RecordAPIAction) {
   base::ScopedTempDir temp_dir;
   base::FilePath db_file;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   activity_db->SetBatchModeForTesting(false);
-  ASSERT_TRUE(activity_db->is_db_valid());
   scoped_refptr<APIAction> action = new APIAction(
       "punky",
       base::Time::Now(),
       APIAction::CALL,
       "brewster",
       "woof",
       "extra");
   activity_db->RecordAction(action);
   activity_db->Close();
 
@@ skipping 12 matching lines @@
 }
 
 // Check that DOM actions are recorded in the db.
 TEST_F(ActivityDatabaseTest, RecordDOMAction) {
   base::ScopedTempDir temp_dir;
   base::FilePath db_file;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   activity_db->SetBatchModeForTesting(false);
-  ASSERT_TRUE(activity_db->is_db_valid());
   scoped_refptr<DOMAction> action = new DOMAction(
       "punky",
       base::Time::Now(),
       DomActionType::MODIFIED,
       GURL("http://www.google.com/foo?bar"),
       string16(),
       "lets",
       "vamoose",
       "extra");
   activity_db->RecordAction(action);
@@ skipping 21 matching lines @@
 }
 
 // Check that blocked actions are recorded in the db.
 TEST_F(ActivityDatabaseTest, RecordBlockedAction) {
   base::ScopedTempDir temp_dir;
   base::FilePath db_file;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
-  ASSERT_TRUE(activity_db->is_db_valid());
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   scoped_refptr<BlockedAction> action = new BlockedAction(
       "punky",
       base::Time::Now(),
       "do.evilThings",
       "1, 2",
       BlockedAction::ACCESS_DENIED,
       "extra");
   activity_db->RecordAction(action);
   activity_db->Close();
 
@@ skipping 20 matching lines @@
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
   // Use a mock clock to ensure that events are not recorded on the wrong day
   // when the test is run close to local midnight.
   base::SimpleTestClock mock_clock;
   mock_clock.SetNow(base::Time::Now().LocalMidnight() +
                     base::TimeDelta::FromHours(12));
 
   // Record some actions
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
-  ASSERT_TRUE(activity_db->is_db_valid());
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   scoped_refptr<APIAction> api_action = new APIAction(
       "punky",
       mock_clock.Now() - base::TimeDelta::FromMinutes(40),
       APIAction::CALL,
       "brewster",
       "woof",
       "extra");
   scoped_refptr<DOMAction> dom_action = new DOMAction(
       "punky",
       mock_clock.Now(),
@@ skipping 37 matching lines @@
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
   // Use a mock clock to ensure that events are not recorded on the wrong day
   // when the test is run close to local midnight.
   base::SimpleTestClock mock_clock;
   mock_clock.SetNow(base::Time::Now().LocalMidnight() +
                     base::TimeDelta::FromHours(12));
 
   // Record some actions
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
-  ASSERT_TRUE(activity_db->is_db_valid());
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   scoped_refptr<APIAction> api_action = new APIAction(
       "punky",
       mock_clock.Now() - base::TimeDelta::FromDays(3)
           - base::TimeDelta::FromMinutes(40),
       APIAction::CALL,
       "brewster",
       "woof",
       "extra");
   scoped_refptr<DOMAction> dom_action = new DOMAction(
       "punky",
@@ skipping 47 matching lines @@
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
   // Use a mock clock to ensure that events are not recorded on the wrong day
   // when the test is run close to local midnight.
   base::SimpleTestClock mock_clock;
   mock_clock.SetNow(base::Time::Now().LocalMidnight() +
                     base::TimeDelta::FromHours(12));
 
   // Record some actions
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   activity_db->SetBatchModeForTesting(false);
   activity_db->SetClockForTesting(&mock_clock);
-  ASSERT_TRUE(activity_db->is_db_valid());
   scoped_refptr<APIAction> api_action = new APIAction(
       "punky",
       mock_clock.Now() - base::TimeDelta::FromMinutes(40),
       APIAction::CALL,
       "brewster",
       "woof",
       "extra");
   activity_db->RecordAction(api_action);
 
   scoped_ptr<std::vector<scoped_refptr<Action> > > actions =
       activity_db->GetActions("punky", 0);
   ASSERT_EQ(1, static_cast<int>(actions->size()));
   activity_db->Close();
 }
 
 TEST_F(ActivityDatabaseTest, BatchModeOn) {
   base::ScopedTempDir temp_dir;
   base::FilePath db_file;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
   // Use a mock clock to set the time, and a special timer to control the
   // timing and skip ahead in time.
   base::SimpleTestClock mock_clock;
   mock_clock.SetNow(base::Time::Now().LocalMidnight() +
                     base::TimeDelta::FromHours(11));
 
   // Record some actions
-  ActivityDatabase* activity_db = new ActivityDatabase();
-  activity_db->Init(db_file);
+  ActivityDatabase* activity_db = OpenDatabase(db_file);
   activity_db->SetBatchModeForTesting(true);
   activity_db->SetClockForTesting(&mock_clock);
-  ASSERT_TRUE(activity_db->is_db_valid());
   scoped_refptr<APIAction> api_action = new APIAction(
       "punky",
       mock_clock.Now() - base::TimeDelta::FromMinutes(40),
       APIAction::CALL,
       "brewster",
       "woof",
       "extra");
   activity_db->RecordAction(api_action);
 
   scoped_ptr<std::vector<scoped_refptr<Action> > > actions_before =
@@ skipping 12 matching lines @@
 }
 
 // Check that nothing explodes if the DB isn't initialized.
 TEST_F(ActivityDatabaseTest, InitFailure) {
   base::ScopedTempDir temp_dir;
   base::FilePath db_file;
   ASSERT_TRUE(temp_dir.CreateUniqueTempDir());
   db_file = temp_dir.path().AppendASCII("ActivityRecord.db");
   base::Delete(db_file, false);
 
-  ActivityDatabase* activity_db = new ActivityDatabase();
+  ActivityDatabase* activity_db =
+      new ActivityDatabase(new ActivityDatabaseTestPolicy());
   scoped_refptr<APIAction> action = new APIAction(
       "punky",
       base::Time::Now(),
       APIAction::CALL,
       "brewster",
       "woooof",
       "extra");
   activity_db->RecordAction(action);
   activity_db->Close();
 }
 
 }  // namespace extensions