Extension activity log database refactoring (step 1)

chrome/browser/extensions/activity_log/activity_log.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <set>
 #include <vector>
 #include "base/command_line.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/logging.h"
 #include "base/strings/string_util.h"
@@ skipping 114 matching lines @@
 }
 
 ActivityLogFactory::~ActivityLogFactory() {
 }
 
 // ActivityLog
 
 void ActivityLog::SetDefaultPolicy(ActivityLogPolicy::PolicyType policy_type) {
   // Can't use IsLogEnabled() here because this is called from inside Init.
   if (policy_type != policy_type_ && enabled_) {
-    delete policy_;
+    // Changing policies once one has been installed is not currently
+    // supported.  After calling Close() on the old policy, there is no way to
+    // wait for changes to be flushed to disk to know that it is safe to
+    // potentially reopen the database with a new policy.
+    CHECK(policy_ == NULL);

[felt, 2013/07/10 18:35:17]

Can you make this a DCHECK?

     switch (policy_type) {
       case ActivityLogPolicy::POLICY_FULLSTREAM:
         policy_ = new FullStreamUIPolicy(profile_);
         break;
       case ActivityLogPolicy::POLICY_NOARGS:
         policy_ = new StreamWithoutArgsUIPolicy(profile_);
         break;
       default:
         NOTREACHED();
     }
@@ skipping 54 matching lines @@
     SetDefaultPolicy(ActivityLogPolicy::POLICY_FULLSTREAM);
   else
     SetDefaultPolicy(ActivityLogPolicy::POLICY_NOARGS);
 }
 
 void ActivityLog::Shutdown() {
   if (tracker_) tracker_->RemoveObserver(this);
 }
 
 ActivityLog::~ActivityLog() {
-  // TODO(felt): Turn policy_ into a scoped_ptr.
-  delete policy_;
+  policy_->Close();
 }
 
 bool ActivityLog::IsLogEnabled() {
   if (!has_threads_ || !initialized_) return false;
   return enabled_;
 }
 
 void ActivityLog::OnExtensionInstalled(const Extension* extension) {
   if (extension->id() != kActivityLogExtensionId) return;
   enabled_ = true;
@@ skipping 282 matching lines @@
                    web_contents->GetTitle(),
                    std::string(),  // no api call here
                    script_names.get(),
                    DomActionType::INSERTED,
                    extra);
     }
   }
 }
 
 }  // namespace extensions