Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(895)

Issue 18660002: Refactor MacroAssembler::Allocate a little bit for X64 (Closed)

Created:
7 years, 5 months ago by haitao.feng
Modified:
7 years, 5 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor MacroAssembler::Allocate a little bit for X64 R=hpayer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=15532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -53 lines) Patch
M src/x64/macro-assembler-x64.cc View 4 chunks +9 lines, -53 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
haitao.feng
PTAL. For X32, we need to check double alignment when allocating objects, so I move ...
7 years, 5 months ago (2013-07-04 03:01:56 UTC) #1
Hannes Payer (out of office)
LGTM!
7 years, 5 months ago (2013-07-08 07:54:37 UTC) #2
Hannes Payer (out of office)
7 years, 5 months ago (2013-07-08 08:10:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r15532 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698