Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 1865953003: sRGB text fake-gamma progress (Closed)

Created:
4 years, 8 months ago by Brian Osman
Modified:
4 years, 8 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

sRGB text fake-gamma progress: Determine if we should use fake-gamma based on the render target format and paint parameters (ie will gamma-correct blending happen?). Plumb that down to the appropriate places in the bitmap text rendering for now. Still need to alter the behavior of the DF text renderer (using the same cue, most likely?). Also, this still doesn't account for the contrast hack. The end result of this change is a pleasant normalizing of weight when viewing text in the gpusrgb config. (Dark text gets heavier, light text gets lighter). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865953003 Committed: https://skia.googlesource.com/skia/+/32f7782706fbf692c613457a74d080e18e27b15a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -32 lines) Patch
M src/gpu/text/GrAtlasTextContext.h View 3 chunks +8 lines, -3 lines 0 comments Download
M src/gpu/text/GrAtlasTextContext.cpp View 17 chunks +34 lines, -15 lines 0 comments Download
M src/gpu/text/GrTextUtils.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/gpu/text/GrTextUtils.cpp View 9 chunks +14 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Brian Osman
4 years, 8 months ago (2016-04-06 20:51:47 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865953003/1
4 years, 8 months ago (2016-04-06 20:54:05 UTC) #6
bungeman-skia
Passing the right setting around (instead of hard-coding it) seems like a good idea to ...
4 years, 8 months ago (2016-04-06 21:05:19 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 21:09:51 UTC) #9
jvanverth1
On 2016/04/06 21:05:19, bungeman1 wrote: > Passing the right setting around (instead of hard-coding it) ...
4 years, 8 months ago (2016-04-07 13:22:28 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865953003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865953003/1
4 years, 8 months ago (2016-04-07 13:24:48 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 13:25:49 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/32f7782706fbf692c613457a74d080e18e27b15a

Powered by Google App Engine
This is Rietveld 408576698