third_party/WebKit/LayoutTests/media/media-play-promise-expected.txt - Issue 1865933002: Fix race when HTMLMediaElement.play() is called just after pause().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/media/media-play-promise-expected.txt

Issue 1865933002: Fix race when HTMLMediaElement.play() is called just after pause(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expectations Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/media/media-play-promise.html ('k') | third_party/WebKit/Source/core/html/HTMLMediaElement.h » ('j') | third_party/WebKit/Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/media/media-play-promise-expected.txt

diff --git a/third_party/WebKit/LayoutTests/media/media-play-promise-expected.txt b/third_party/WebKit/LayoutTests/media/media-play-promise-expected.txt

index 3a78c525b939bf9371b047a0333e3236a32b9610..d1418ac89d7b8d9139a66acac9c390b1a7cedf01 100644

--- a/third_party/WebKit/LayoutTests/media/media-play-promise-expected.txt

+++ b/third_party/WebKit/LayoutTests/media/media-play-promise-expected.txt

@@ -167,5 +167,20 @@ play()

RUN(mediaElement.volume = 0.2)

arguments.length: 1

Promise failed with NotSupportedError: The element has no supported sources.

+pausePlayAfterPlaybackStarted()

+RUN(mediaElement = document.createElement('audio'))

+RUN(mediaElement.src = 'content/test.wav')

+EVENT(volumechange)

+EVENT(canplaythrough)

+RUN(mediaElement.play())

+EVENT(playing)

+EXPECTED (mediaElement.readyState == '4') OK

+EXPECTED (mediaElement.paused == 'false') OK

+RUN(mediaElement.pause())

+play()

+arguments.length: 1

+Promise resolved with undefined

END OF TEST