Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 186593006: Copy msvc*.dll from the build_dir to the installer_dir rather than straight to the installer_dir as… (Closed)

Created:
6 years, 9 months ago by gab
Modified:
6 years, 9 months ago
Reviewers:
robertshield
CC:
chromium-reviews
Visibility:
Public.

Description

Copy msvc*.dll from the build_dir to the installer_dir rather than straight to the installer_dir as some DLLs only live in the build_dir and aren't grabbed by CopyVisualStudioRuntimeDLLs(). NOTRY=True BUG=349419 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255435

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M chrome/tools/build/win/create_installer_archive.py View 2 chunks +19 lines, -20 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
gab
Robert PTAL. Thanks! Gab
6 years, 9 months ago (2014-03-06 18:35:15 UTC) #1
robertshield
lgtm
6 years, 9 months ago (2014-03-06 18:40:58 UTC) #2
gab
The CQ bit was checked by gab@chromium.org
6 years, 9 months ago (2014-03-06 18:50:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/186593006/1
6 years, 9 months ago (2014-03-06 18:51:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/186593006/1
6 years, 9 months ago (2014-03-06 20:57:28 UTC) #5
commit-bot: I haz the power
6 years, 9 months ago (2014-03-06 21:29:11 UTC) #6
Message was sent while issue was closed.
Change committed as 255435

Powered by Google App Engine
This is Rietveld 408576698