third_party/WebKit/public/platform/modules/webusb/WebUSBClient.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/webusb/WebUSBClient.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistrationProxy.h ('k') | third_party/WebKit/public/platform/modules/webusb/WebUSBDevice.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/webusb/WebUSBClient.h

diff --git a/third_party/WebKit/public/platform/modules/webusb/WebUSBClient.h b/third_party/WebKit/public/platform/modules/webusb/WebUSBClient.h

index 18c4a5c8d06876778331c31d9e58cd3ec91f84d1..2dee386511abc93580b31e63a27116ccb48dffd8 100644

--- a/third_party/WebKit/public/platform/modules/webusb/WebUSBClient.h

+++ b/third_party/WebKit/public/platform/modules/webusb/WebUSBClient.h

@@ -14,8 +14,8 @@ class WebUSBDevice;

struct WebUSBDeviceRequestOptions;

struct WebUSBError;

-using WebUSBClientGetDevicesCallbacks = WebCallbacks<WebPassOwnPtr<WebVector<WebUSBDevice*>>, const WebUSBError&>;

-using WebUSBClientRequestDeviceCallbacks = WebCallbacks<WebPassOwnPtr<WebUSBDevice>, const WebUSBError&>;

+using WebUSBClientGetDevicesCallbacks = WebCallbacks<std::unique_ptr<WebVector<WebUSBDevice*>>, const WebUSBError&>;

+using WebUSBClientRequestDeviceCallbacks = WebCallbacks<std::unique_ptr<WebUSBDevice>, const WebUSBError&>;

class WebUSBClient {

public:

@@ -24,10 +24,10 @@ public:

virtual ~Observer() { }

// Called when a device is connected to the system.

- virtual void onDeviceConnected(WebPassOwnPtr<WebUSBDevice>) = 0;

+ virtual void onDeviceConnected(std::unique_ptr<WebUSBDevice>) = 0;

// Called when a device is disconnected from the system.

- virtual void onDeviceDisconnected(WebPassOwnPtr<WebUSBDevice>) = 0;

+ virtual void onDeviceDisconnected(std::unique_ptr<WebUSBDevice>) = 0;

};

virtual ~WebUSBClient() { }