third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/modules/presentation/WebPresentationClient.h ('k') | third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerCacheStorage.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h

diff --git a/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h b/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h

index 5de2f8aaae5c625d40bb2b64b7f3d030c86fa0cc..7672c16f4d901e2260a9a7e69651aab0582c08e7 100644

--- a/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h

+++ b/third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h

@@ -6,17 +6,18 @@

#define WebPushProvider_h

#include "public/platform/WebCallbacks.h"

-#include "public/platform/WebPassOwnPtr.h"

#include "public/platform/modules/push_messaging/WebPushPermissionStatus.h"

#include "public/platform/modules/push_messaging/WebPushSubscription.h"

+#include <memory>

namespace blink {

class WebServiceWorkerRegistration;

struct WebPushError;

struct WebPushSubscriptionOptions;

-using WebPushSubscriptionCallbacks = WebCallbacks<WebPassOwnPtr<WebPushSubscription>, const WebPushError&>;

+using WebPushSubscriptionCallbacks = WebCallbacks<std::unique_ptr<WebPushSubscription>, const WebPushError&>;

using WebPushPermissionStatusCallbacks = WebCallbacks<WebPushPermissionStatus, const WebPushError&>;

using WebPushUnsubscribeCallbacks = WebCallbacks<bool, const WebPushError&>;