third_party/WebKit/public/platform/WebViewScheduler.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebViewScheduler.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/WebURLLoaderMockFactory.h ('k') | third_party/WebKit/public/platform/modules/background_sync/WebSyncProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebViewScheduler.h

diff --git a/third_party/WebKit/public/platform/WebViewScheduler.h b/third_party/WebKit/public/platform/WebViewScheduler.h

index a3693f6af743d1bc447ae936d5a107bce1411e80..3635b784a04c751614fee6653e7850d56ea7553a 100644

--- a/third_party/WebKit/public/platform/WebViewScheduler.h

+++ b/third_party/WebKit/public/platform/WebViewScheduler.h

@@ -7,7 +7,8 @@

#include "WebCommon.h"

#include "public/platform/BlameContext.h"

-#include "public/platform/WebPassOwnPtr.h"

+#include <memory>

namespace blink {

@@ -23,7 +24,7 @@ public:

// Creates a new WebFrameScheduler. The caller is responsible for deleting

// it. All tasks executed by the frame scheduler will be attributed to

// |BlameContext|.

- virtual WebPassOwnPtr<WebFrameScheduler> createFrameScheduler(BlameContext*) = 0;

+ virtual std::unique_ptr<WebFrameScheduler> createFrameScheduler(BlameContext*) = 0;

// Instructs this WebViewScheduler to use virtual time. When virtual time is enabled

// the system doesn't actually sleep for the delays between tasks before executing