third_party/WebKit/public/platform/WebRTCCertificate.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebRTCCertificate.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/public/platform/WebPassOwnPtr.h ('k') | third_party/WebKit/public/platform/WebRTCCertificateGenerator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/WebRTCCertificate.h

diff --git a/third_party/WebKit/public/platform/WebRTCCertificate.h b/third_party/WebKit/public/platform/WebRTCCertificate.h

index 4480acf521ecef329ed30c0ac13f8ee95f93db8b..809839266a611882b6fed88293bb59a7d6e43ba6 100644

--- a/third_party/WebKit/public/platform/WebRTCCertificate.h

+++ b/third_party/WebKit/public/platform/WebRTCCertificate.h

@@ -5,9 +5,10 @@

#ifndef WebRTCCertificate_h

#define WebRTCCertificate_h

-#include "public/platform/WebPassOwnPtr.h"

#include "public/platform/WebRTCKeyParams.h"

+#include <memory>

namespace blink {

// WebRTCCertificate is an interface defining what Blink needs to know about certificates,

@@ -23,7 +24,7 @@ public:

// Copies the WebRTCCertificate object without copying the underlying implementation

// specific (WebRTC layer) certificate. When all copies are destroyed the underlying

// data is freed.

- virtual WebPassOwnPtr<WebRTCCertificate> shallowCopy() const = 0;

+ virtual std::unique_ptr<WebRTCCertificate> shallowCopy() const = 0;

virtual const WebRTCKeyParams& keyParams() const = 0;