third_party/WebKit/public/platform/WebCredentialManagerClient.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/WebCredentialManagerClient.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/public/platform/WebCredentialManagerClient.h

diff --git a/third_party/WebKit/public/platform/WebCredentialManagerClient.h b/third_party/WebKit/public/platform/WebCredentialManagerClient.h

index f9e8049257da37bc6d7befa9bdba56e9bd186210..eba06e881f457b90cb7c2be217b640f3e8816b5b 100644

--- a/third_party/WebKit/public/platform/WebCredentialManagerClient.h

+++ b/third_party/WebKit/public/platform/WebCredentialManagerClient.h

@@ -7,9 +7,10 @@

#include "public/platform/WebCallbacks.h"

#include "public/platform/WebCredentialManagerError.h"

-#include "public/platform/WebPassOwnPtr.h"

#include "public/platform/WebVector.h"

+#include <memory>

namespace blink {

class WebCredential;

@@ -20,7 +21,7 @@ class WebURL;

// 'credentialmanager' module.

class WebCredentialManagerClient {

public:

- typedef WebCallbacks<WebPassOwnPtr<WebCredential>, WebCredentialManagerError> RequestCallbacks;

+ typedef WebCallbacks<std::unique_ptr<WebCredential>, WebCredentialManagerError> RequestCallbacks;

typedef WebCallbacks<void, WebCredentialManagerError> NotificationCallbacks;

// Ownership of the callback is transferred to the callee for each of

« no previous file with comments | « third_party/WebKit/public/platform/WebCallbacks.h ('k') | third_party/WebKit/public/platform/WebPassOwnPtr.h » ('j') | no next file with comments »