third_party/WebKit/Source/web/WebViewImpl.cpp - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/web/WebViewImpl.cpp

diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp

index 101b4996b6491be950bf4a55c23d687e70fa289a..d237767450f8e02a82ef7566964235c7b8abd84f 100644

--- a/third_party/WebKit/Source/web/WebViewImpl.cpp

+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp

@@ -444,7 +444,7 @@ WebViewImpl::WebViewImpl(WebViewClient* client)

, m_shouldDispatchFirstLayoutAfterFinishedLoading(false)

, m_displayMode(WebDisplayModeBrowser)

, m_elasticOverscroll(FloatSize())

- , m_scheduler(Platform::current()->currentThread()->scheduler()->createWebViewScheduler(this).release())

+ , m_scheduler(adoptPtr(Platform::current()->currentThread()->scheduler()->createWebViewScheduler(this).release()))

{

Page::PageClients pageClients;

pageClients.chromeClient = m_chromeClientImpl.get();

« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp ('k') | third_party/WebKit/Source/wtf/PtrUtil.h » ('j') | no next file with comments »