third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnectionCallbacks.cpp ('k') | third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h

diff --git a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h

index ecf1758a0b32b2f0745138cdd082ef636cc7ad92..dab9381a1ae4f348228439da74c50aded4134663 100644

--- a/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h

+++ b/third_party/WebKit/Source/modules/push_messaging/PushSubscriptionCallbacks.h

@@ -27,7 +27,7 @@ public:

PushSubscriptionCallbacks(ScriptPromiseResolver*, ServiceWorkerRegistration*);

~PushSubscriptionCallbacks() override;

- void onSuccess(WebPassOwnPtr<WebPushSubscription>) override;

+ void onSuccess(std::unique_ptr<WebPushSubscription>) override;

void onError(const WebPushError&) override;

private: