third_party/WebKit/Source/modules/mediastream/RTCCertificate.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCCertificate.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCCertificate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCCertificate.h

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCCertificate.h b/third_party/WebKit/Source/modules/mediastream/RTCCertificate.h

index d98bba016a2da127fbc5eba3b62d2cb71a93a48f..2cfd63a473890d66fdd292e4f7fd706bec5e4c54 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCCertificate.h

+++ b/third_party/WebKit/Source/modules/mediastream/RTCCertificate.h

@@ -34,20 +34,21 @@

#include "bindings/core/v8/ScriptWrappable.h"

#include "core/dom/DOMTimeStamp.h"

#include "platform/heap/GarbageCollected.h"

-#include "public/platform/WebPassOwnPtr.h"

#include "public/platform/WebRTCCertificate.h"

#include "wtf/OwnPtr.h"

+#include <memory>

namespace blink {

class RTCCertificate final : public GarbageCollectedFinalized<RTCCertificate>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

// Takes ownership of the certificate.

- RTCCertificate(WebPassOwnPtr<WebRTCCertificate>);

+ RTCCertificate(std::unique_ptr<WebRTCCertificate>);

// Returns a new WebRTCCertificate shallow copy.

- WebPassOwnPtr<WebRTCCertificate> certificateShallowCopy() const;

+ std::unique_ptr<WebRTCCertificate> certificateShallowCopy() const;

DEFINE_INLINE_TRACE() {}