third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/background_sync/SyncCallbacks.h ('k') | third_party/WebKit/Source/modules/cachestorage/Cache.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

diff --git a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

index 9e2af89a3640bab5b8cd852574dec70695d51237..9b6e3e7cb993da72fe7a40c85c109755dcd9c5ed 100644

--- a/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

+++ b/third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp

@@ -24,13 +24,13 @@ SyncRegistrationCallbacks::~SyncRegistrationCallbacks()

{

}

-void SyncRegistrationCallbacks::onSuccess(WebPassOwnPtr<WebSyncRegistration> webSyncRegistration)

+void SyncRegistrationCallbacks::onSuccess(std::unique_ptr<WebSyncRegistration> webSyncRegistration)

{

if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped()) {

return;

}

- OwnPtr<WebSyncRegistration> registration = webSyncRegistration.release();

+ OwnPtr<WebSyncRegistration> registration = adoptPtr(webSyncRegistration.release());

if (!registration) {

m_resolver->resolve(v8::Null(m_resolver->getScriptState()->isolate()));

return;