Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Unified Diff: content/renderer/bluetooth/bluetooth_dispatcher.cc

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/bluetooth/bluetooth_dispatcher.cc
diff --git a/content/renderer/bluetooth/bluetooth_dispatcher.cc b/content/renderer/bluetooth/bluetooth_dispatcher.cc
index a4b7b4756cb6591e7f38064b6f0f8eefd9616b92..37805454bfcfa65aaa8d7896a1445bb2c3e070e2 100644
--- a/content/renderer/bluetooth/bluetooth_dispatcher.cc
+++ b/content/renderer/bluetooth/bluetooth_dispatcher.cc
@@ -6,14 +6,17 @@
#include <stddef.h>
+#include <memory>
+#include <utility>
+
#include "base/lazy_instance.h"
+#include "base/memory/ptr_util.h"
#include "base/memory/scoped_ptr.h"
#include "base/message_loop/message_loop.h"
#include "base/thread_task_runner_handle.h"
#include "content/child/thread_safe_sender.h"
#include "content/common/bluetooth/bluetooth_messages.h"
#include "device/bluetooth/bluetooth_uuid.h"
-#include "third_party/WebKit/public/platform/WebPassOwnPtr.h"
#include "third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothDevice.h"
#include "third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothError.h"
#include "third_party/WebKit/public/platform/modules/bluetooth/WebBluetoothRemoteGATTCharacteristic.h"
@@ -591,7 +594,7 @@ void BluetoothDispatcher::OnRequestDeviceSuccess(
uuids[i] = WebString::fromUTF8(device.uuids[i].c_str());
pending_requests_.Lookup(request_id)
- ->onSuccess(blink::adoptWebPtr(new WebBluetoothDevice(
+ ->onSuccess(base::WrapUnique(new WebBluetoothDevice(
WebString::fromUTF8(device.id), WebString(device.name),
device.tx_power, device.rssi, device.device_class,
GetWebVendorIdSource(device.vendor_id_source), device.vendor_id,
@@ -631,7 +634,7 @@ void BluetoothDispatcher::OnGetPrimaryServiceSuccess(
BluetoothPrimaryServiceRequest* request =
pending_primary_service_requests_.Lookup(request_id);
request->callbacks->onSuccess(
- blink::adoptWebPtr(new WebBluetoothRemoteGATTService(
+ base::WrapUnique(new WebBluetoothRemoteGATTService(
WebString::fromUTF8(service_instance_id), request->service_uuid,
true /* isPrimary */, request->device_id)));
pending_primary_service_requests_.Remove(request_id);
@@ -657,7 +660,7 @@ void BluetoothDispatcher::OnGetCharacteristicSuccess(
BluetoothCharacteristicRequest* request =
pending_characteristic_requests_.Lookup(request_id);
request->callbacks->onSuccess(
- blink::adoptWebPtr(new WebBluetoothRemoteGATTCharacteristicInit(
+ base::WrapUnique(new WebBluetoothRemoteGATTCharacteristicInit(
request->service_instance_id,
WebString::fromUTF8(characteristic_instance_id),
request->characteristic_uuid, characteristic_properties)));
@@ -687,9 +690,10 @@ void BluetoothDispatcher::OnGetCharacteristicsSuccess(
BluetoothCharacteristicsRequest* request =
pending_characteristics_requests_.Lookup(request_id);
- WebVector<blink::WebBluetoothRemoteGATTCharacteristicInit*>* characteristics =
- new WebVector<WebBluetoothRemoteGATTCharacteristicInit*>(
- characteristics_instance_ids.size());
+ // TODO(dcheng): This WebVector should use smart pointers.
+ std::unique_ptr<WebVector<blink::WebBluetoothRemoteGATTCharacteristicInit*>>
+ characteristics(new WebVector<WebBluetoothRemoteGATTCharacteristicInit*>(
+ characteristics_instance_ids.size()));
for (size_t i = 0; i < characteristics_instance_ids.size(); i++) {
(*characteristics)[i] = new WebBluetoothRemoteGATTCharacteristicInit(
@@ -699,7 +703,7 @@ void BluetoothDispatcher::OnGetCharacteristicsSuccess(
characteristics_properties[i]);
}
- request->callbacks->onSuccess(blink::adoptWebPtr(characteristics));
+ request->callbacks->onSuccess(std::move(characteristics));
pending_characteristics_requests_.Remove(request_id);
}

Powered by Google App Engine
This is Rietveld 408576698