content/child/service_worker/web_service_worker_impl.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_impl.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher_unittest.cc ('k') | content/child/service_worker/web_service_worker_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_impl.h

diff --git a/content/child/service_worker/web_service_worker_impl.h b/content/child/service_worker/web_service_worker_impl.h

index 48a323750b6747af3922f5fd3a547b30844ad019..b5ba50526335c879fb296cbdfdec2bebc3b16da9 100644

--- a/content/child/service_worker/web_service_worker_impl.h

+++ b/content/child/service_worker/web_service_worker_impl.h

@@ -5,6 +5,7 @@

#ifndef CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_IMPL_H_

#define CONTENT_CHILD_SERVICE_WORKER_WEB_SERVICE_WORKER_IMPL_H_

+#include <memory>

#include <vector>

#include "base/compiler_specific.h"

@@ -14,7 +15,6 @@

#include "base/strings/string16.h"

#include "content/common/content_export.h"

#include "third_party/WebKit/public/platform/WebMessagePortChannel.h"

-#include "third_party/WebKit/public/platform/WebPassOwnPtr.h"

#include "third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorker.h"

#include "third_party/WebKit/public/web/WebFrame.h"

@@ -57,7 +57,7 @@ class CONTENT_EXPORT WebServiceWorkerImpl

// Creates WebServiceWorker::Handle object that owns a reference to the given

// WebServiceWorkerImpl object.

- static blink::WebPassOwnPtr<blink::WebServiceWorker::Handle> CreateHandle(

+ static std::unique_ptr<blink::WebServiceWorker::Handle> CreateHandle(

const scoped_refptr<WebServiceWorkerImpl>& worker);

private: