third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp ('K') | « third_party/WebKit/Source/modules/cachestorage/Cache.cpp ('k') | third_party/WebKit/Source/modules/cachestorage/InspectorCacheStorageAgent.cpp » ('j') | third_party/WebKit/public/platform/WebCallbacks.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

diff --git a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

index f0fed5dd0500d5e0c0c64cfdd6a8a055adf601f1..23a1236f34a98491667f8f614adfc89c4b127622 100644

--- a/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

+++ b/third_party/WebKit/Source/modules/cachestorage/CacheStorage.cpp

@@ -91,11 +91,11 @@ public:

: m_cacheName(cacheName), m_cacheStorage(cacheStorage), m_resolver(resolver) { }

~WithCacheCallbacks() override { }

- void onSuccess(WebPassOwnPtr<WebServiceWorkerCache> webCache) override

+ void onSuccess(std::unique_ptr<WebServiceWorkerCache> webCache) override

{

if (!m_resolver->getExecutionContext() || m_resolver->getExecutionContext()->activeDOMObjectsAreStopped())

return;

- Cache* cache = Cache::create(m_cacheStorage->m_scopedFetcher, webCache.release());

+ Cache* cache = Cache::create(m_cacheStorage->m_scopedFetcher, adoptPtr(webCache.release()));

m_cacheStorage->m_nameToCacheMap.set(m_cacheName, cache);

m_resolver->resolve(cache);

m_resolver.clear();