content/child/service_worker/web_service_worker_registration_impl.h - Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 1865913005: Nuke WebPassOwnPtr<T> and replace it with std::unique_ptr<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_impl.cc ('k') | content/child/service_worker/web_service_worker_registration_impl.cc » ('j') | third_party/WebKit/Source/modules/background_sync/SyncCallbacks.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.h

diff --git a/content/child/service_worker/web_service_worker_registration_impl.h b/content/child/service_worker/web_service_worker_registration_impl.h

index 41da2774926a4fe6595c71b7eb490b8f688b0834..2c8d3c9456d40ab26cf7aa80589ab57a45dd808a 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.h

+++ b/content/child/service_worker/web_service_worker_registration_impl.h

@@ -12,6 +12,7 @@

#include "base/compiler_specific.h"

#include "base/macros.h"

#include "base/memory/ref_counted.h"

+#include "base/memory/scoped_ptr.h"

#include "content/common/content_export.h"

#include "third_party/WebKit/public/platform/modules/serviceworker/WebServiceWorkerRegistration.h"

@@ -62,7 +63,7 @@ class CONTENT_EXPORT WebServiceWorkerRegistrationImpl

// Creates WebServiceWorkerRegistrationHandle object that owns a reference to

// the given WebServiceWorkerRegistrationImpl object.

- static blink::WebPassOwnPtr<WebServiceWorkerRegistrationHandle> CreateHandle(

+ static std::unique_ptr<WebServiceWorkerRegistrationHandle> CreateHandle(

const scoped_refptr<WebServiceWorkerRegistrationImpl>& registration);

// Same with CreateHandle(), but returns a raw pointer to the handle w/ its