Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1865893002:
S390: Fix incorrect V8_HOST_ARCH_S390X to V8_TARGET_ARCH_S390X (Closed)
DescriptionS390: Fix incorrect V8_HOST_ARCH_S390X to V8_TARGET_ARCH_S390X
V8_HOST_ARCH_S390X doesn't exist but is incorrectly used. Therefore, preserved floating point registers are not being correctly saved/restored in JSEntryStub.
R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com
BUG=
Committed: https://crrev.com/b6d446635a42ac4a7d72a006bc1eb306884c7725
Cr-Commit-Position: refs/heads/master@{#35311}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
PTAL
lgtm
Description was changed from ========== S390: Update incorrect V8_HOST_ARCH_S390X as V8_TARGET_ARCH_S390X V8_HOST_ARCH_S390X doesn't exist but is incorrectly used. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= ========== to ========== S390: Fix incorrect V8_HOST_ARCH_S390X to V8_TARGET_ARCH_S390X V8_HOST_ARCH_S390X doesn't exist but is incorrectly used. Therefore, preserved floating point registers are not being correctly saved/restored in JSEntryStub. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= ==========
The CQ bit was checked by jyan@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865893002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/18021)
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865893002/1
The CQ bit was unchecked by jyan@ca.ibm.com
The CQ bit was checked by jyan@ca.ibm.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865893002/1
hmm - looks like cq got bothered by a master restart and hangs. Will see if I can cancel manually.
Message was sent while issue was closed.
Description was changed from ========== S390: Fix incorrect V8_HOST_ARCH_S390X to V8_TARGET_ARCH_S390X V8_HOST_ARCH_S390X doesn't exist but is incorrectly used. Therefore, preserved floating point registers are not being correctly saved/restored in JSEntryStub. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= ========== to ========== S390: Fix incorrect V8_HOST_ARCH_S390X to V8_TARGET_ARCH_S390X V8_HOST_ARCH_S390X doesn't exist but is incorrectly used. Therefore, preserved floating point registers are not being correctly saved/restored in JSEntryStub. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== S390: Fix incorrect V8_HOST_ARCH_S390X to V8_TARGET_ARCH_S390X V8_HOST_ARCH_S390X doesn't exist but is incorrectly used. Therefore, preserved floating point registers are not being correctly saved/restored in JSEntryStub. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= ========== to ========== S390: Fix incorrect V8_HOST_ARCH_S390X to V8_TARGET_ARCH_S390X V8_HOST_ARCH_S390X doesn't exist but is incorrectly used. Therefore, preserved floating point registers are not being correctly saved/restored in JSEntryStub. R=joransiu@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG= Committed: https://crrev.com/b6d446635a42ac4a7d72a006bc1eb306884c7725 Cr-Commit-Position: refs/heads/master@{#35311} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b6d446635a42ac4a7d72a006bc1eb306884c7725 Cr-Commit-Position: refs/heads/master@{#35311}
Message was sent while issue was closed.
On 2016/04/06 18:52:56, Michael Achenbach wrote: > hmm - looks like cq got bothered by a master restart and hangs. Will see if I > can cancel manually. thanks Michael! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
