remove agg from skia driver

remove agg from skia driver

Copy code from the agg driver so that the Skia
driver is no longer dependent on it.

The copied code doesn't in turn call
agg; it was in the agg driver for convenience.

Much of the copied code will eventually be replaced
by native Skia code, so there's not much point
in rewriting it to make it more efficient or
maintainable.

R=dsinclair@chromium.org,tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/392f1022a3c525a053a7d143d2b23a76526a1aea

[caryclark, 2016-04-06 12:57:01]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 12:57:05]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865883002/1

[commit-bot: I haz the power, 2016-04-06 13:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 13:08:59]

Dry run: This issue passed the CQ dry run.

[dsinclair, 2016-04-06 13:30:30]

lgtm.

Does this mean we can either ifdef out the agg code if not skia, or change the
build rules to remove it?

[caryclark, 2016-04-06 13:44:12]

On 2016/04/06 13:30:30, dsinclair wrote:
> lgtm.
> 
> Does this mean we can either ifdef out the agg code if not skia, or change the
> build rules to remove it?

Not yet. For instance, in fpdfview.cpp, there's this code:

  if (bBackgroundAlphaNeeded || bHasImageMask) {
    .. call Skia ..
  } else {
    pContext->m_pDevice = new CFX_WindowsDevice(dc);
  }

which in turn, eventually gets to CGdiDeviceDriver::DrawLine
in fx_win32_device.cpp which calls agg::clip_liang_barsky ...

I don't know how to trigger this code path -- once I can
remove it, then I agree, agg can be ifdef'd out.

[caryclark, 2016-04-06 14:37:48]

The CQ bit was checked by caryclark@google.com

[commit-bot: I haz the power, 2016-04-06 14:37:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865883002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865883002/1

[commit-bot: I haz the power, 2016-04-06 14:38:17]

Description was changed from

==========
remove agg from skia driver

Copy code from the agg driver so that the Skia
driver is no longer dependent on it.

The copied code doesn't in turn call
agg; it was in the agg driver for convenience.

Much of the copied code will eventually be replaced
by native Skia code, so there's not much point
in rewriting it to make it more efficient or
maintainable.

R=dsinclair@chromium.org,tsepez@chromium.org
==========

to

==========
remove agg from skia driver

Copy code from the agg driver so that the Skia
driver is no longer dependent on it.

The copied code doesn't in turn call
agg; it was in the agg driver for convenience.

Much of the copied code will eventually be replaced
by native Skia code, so there's not much point
in rewriting it to make it more efficient or
maintainable.

R=dsinclair@chromium.org,tsepez@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/392f1022a3c525a053a7d143d2b23a76526a...
==========

[commit-bot: I haz the power, 2016-04-06 14:38:18]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/392f1022a3c525a053a7d143d2b23a76526a...