Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1865883002: remove agg from skia driver (Closed)

Created:
4 years, 8 months ago by caryclark
Modified:
4 years, 8 months ago
Reviewers:
Tom Sepez, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

remove agg from skia driver Copy code from the agg driver so that the Skia driver is no longer dependent on it. The copied code doesn't in turn call agg; it was in the agg driver for convenience. Much of the copied code will eventually be replaced by native Skia code, so there's not much point in rewriting it to make it more efficient or maintainable. R=dsinclair@chromium.org,tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/392f1022a3c525a053a7d143d2b23a76526a1aea

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+208 lines, -30 lines) Patch
M core/fxge/skia/fx_skia_device.h View 2 chunks +6 lines, -3 lines 0 comments Download
M core/fxge/skia/fx_skia_device.cpp View 7 chunks +202 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865883002/1
4 years, 8 months ago (2016-04-06 12:57:05 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 13:08:59 UTC) #4
dsinclair
lgtm. Does this mean we can either ifdef out the agg code if not skia, ...
4 years, 8 months ago (2016-04-06 13:30:30 UTC) #5
caryclark
On 2016/04/06 13:30:30, dsinclair wrote: > lgtm. > > Does this mean we can either ...
4 years, 8 months ago (2016-04-06 13:44:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865883002/1
4 years, 8 months ago (2016-04-06 14:37:59 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 14:38:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/392f1022a3c525a053a7d143d2b23a76526a...

Powered by Google App Engine
This is Rietveld 408576698