Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1865863003: Cleanup IC-related code (Closed)

Created:
4 years, 8 months ago by Toon Verwaest
Modified:
4 years, 8 months ago
Reviewers:
mvstanton, ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Cleanup IC-related code BUG= Committed: https://crrev.com/787516891f8b2907fd4ae1d2fc46a104b004075d Cr-Commit-Position: refs/heads/master@{#35297}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -410 lines) Patch
M src/heap/objects-visiting-inl.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ic/ic.h View 1 2 3 15 chunks +11 lines, -48 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 34 chunks +78 lines, -162 lines 0 comments Download
M src/ic/ic-inl.h View 1 chunk +1 line, -31 lines 0 comments Download
M src/objects.h View 1 2 4 chunks +0 lines, -22 lines 0 comments Download
M src/objects.cc View 1 2 1 chunk +1 line, -113 lines 0 comments Download
M src/objects-inl.h View 1 2 1 chunk +0 lines, -10 lines 0 comments Download
M src/type-info.h View 3 chunks +4 lines, -6 lines 0 comments Download
M src/type-info.cc View 3 chunks +14 lines, -16 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865863003/1
4 years, 8 months ago (2016-04-06 10:54:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865863003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865863003/40001
4 years, 8 months ago (2016-04-06 11:28:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865863003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865863003/80001
4 years, 8 months ago (2016-04-06 11:41:46 UTC) #6
Toon Verwaest
mvstanton: ptal ulan: ptal @ heap
4 years, 8 months ago (2016-04-06 11:49:06 UTC) #8
ulan
heap lgtm, yay for removing special case :)
4 years, 8 months ago (2016-04-06 11:52:26 UTC) #9
mvstanton
LGTM, nice.
4 years, 8 months ago (2016-04-06 11:53:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865863003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865863003/80001
4 years, 8 months ago (2016-04-06 12:03:39 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-06 12:06:51 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 12:07:52 UTC) #16
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/787516891f8b2907fd4ae1d2fc46a104b004075d
Cr-Commit-Position: refs/heads/master@{#35297}

Powered by Google App Engine
This is Rietveld 408576698