Add android_libcpp_lib_dir gn arg

Add android_libcpp_lib_dir gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
Committed: https://crrev.com/81f01675f95fdf819d374b36234765d7dcb228ab
Cr-Commit-Position: refs/heads/master@{#385679}

[tsniatowski, 2016-04-06 09:28:14]

Description was changed from

==========
Add android_libcpp_lib_dir_override gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
==========

to

==========
Add android_libcpp_lib_dir_override gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
==========

[tsniatowski, 2016-04-06 09:28:14]

tsniatowski@opera.com changed reviewers:
+ agrieve@chromium.org

[tsniatowski, 2016-04-06 09:28:40]

PTAL

[agrieve, 2016-04-06 14:28:45]

lgtm assuming one change

https://codereview.chromium.org/1865853002/diff/1/build/config/android/config...
File build/config/android/config.gni (right):

https://codereview.chromium.org/1865853002/diff/1/build/config/android/config...
build/config/android/config.gni:54: android_libcpp_lib_dir_override = ""
I don't think it's common / necessary to have "override" in the name here. It's
just causing two new global variables to exist.

Instead, call it "android_libcpp_lib_dir",

then below, set it to the default if it's ""

[tsniatowski, 2016-04-07 05:47:28]

Description was changed from

==========
Add android_libcpp_lib_dir_override gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
==========

to

==========
Add android_libcpp_lib_dir gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
==========

[tsniatowski, 2016-04-07 05:49:03]

On 2016/04/06 14:28:45, agrieve wrote:
> lgtm assuming one change
> 
>
https://codereview.chromium.org/1865853002/diff/1/build/config/android/config...
> File build/config/android/config.gni (right):
> 
>
https://codereview.chromium.org/1865853002/diff/1/build/config/android/config...
> build/config/android/config.gni:54: android_libcpp_lib_dir_override = ""
> I don't think it's common / necessary to have "override" in the name here.
It's
> just causing two new global variables to exist.
> 
> Instead, call it "android_libcpp_lib_dir",
> 
> then below, set it to the default if it's ""

Good point, done that.

[tsniatowski, 2016-04-07 05:49:04]

On 2016/04/06 14:28:45, agrieve wrote:
> lgtm assuming one change
> 
>
https://codereview.chromium.org/1865853002/diff/1/build/config/android/config...
> File build/config/android/config.gni (right):
> 
>
https://codereview.chromium.org/1865853002/diff/1/build/config/android/config...
> build/config/android/config.gni:54: android_libcpp_lib_dir_override = ""
> I don't think it's common / necessary to have "override" in the name here.
It's
> just causing two new global variables to exist.
> 
> Instead, call it "android_libcpp_lib_dir",
> 
> then below, set it to the default if it's ""

Good point, done that.

[tsniatowski, 2016-04-07 05:49:28]

The CQ bit was checked by tsniatowski@opera.com

[tsniatowski, 2016-04-07 05:49:28]

The patchset sent to the CQ was uploaded after l-g-t-m from agrieve@chromium.org
Link to the patchset: https://codereview.chromium.org/1865853002/#ps20001
(title: "use a single variable")

[commit-bot: I haz the power, 2016-04-07 05:49:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865853002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865853002/20001

[commit-bot: I haz the power, 2016-04-07 06:29:00]

Description was changed from

==========
Add android_libcpp_lib_dir gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
==========

to

==========
Add android_libcpp_lib_dir gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
==========

[commit-bot: I haz the power, 2016-04-07 06:29:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-07 06:29:39]

Description was changed from

==========
Add android_libcpp_lib_dir gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249
==========

to

==========
Add android_libcpp_lib_dir gn arg

Port android_libcpp_libs_dir from gyp, where it was possible to override
this directory. Allows using a custom libc++ easily.

BUG=359249

Committed: https://crrev.com/81f01675f95fdf819d374b36234765d7dcb228ab
Cr-Commit-Position: refs/heads/master@{#385679}
==========

[commit-bot: I haz the power, 2016-04-07 06:29:40]

Patchset 2 (id:??) landed as
https://crrev.com/81f01675f95fdf819d374b36234765d7dcb228ab
Cr-Commit-Position: refs/heads/master@{#385679}