Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1865813002: Remove RawPtr from Source/web/ (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
CC:
dcheng, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dglazkov+blink, eric.carlson_apple.com, falken, feature-media-reviews_chromium.org, horo+watch_chromium.org, kinuko+worker_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, pfeldman+blink_chromium.org, philipj_slow, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RawPtr from Source/web/ BUG=585328 Committed: https://crrev.com/36eee5a33fff7b046946db6d0f8f80a60f3e2057 Cr-Commit-Position: refs/heads/master@{#386075}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+427 lines, -477 lines) Patch
M third_party/WebKit/Source/core/editing/SurroundingText.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/SurroundingText.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerObjectProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerObjectProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerReportingProxy.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/workers/WorkerThreadTestHelper.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/compositorworker/CompositorWorkerThreadTest.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AssociatedURLLoader.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/AudioOutputDeviceClientImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ColorChooserPopupUIController.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ColorChooserUIController.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ContextMenuClientImpl.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/DatabaseClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DatabaseClientImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DateTimeChooserImpl.cpp View 1 2 3 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/DragClientImpl.cpp View 1 2 3 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalDateTimeChooser.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ExternalDateTimeChooser.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 1 2 3 3 chunks +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenuTest.cpp View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp View 1 2 3 3 chunks +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/FullscreenController.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/GeolocationClientProxy.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorEmulationAgent.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 2 3 4 5 4 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorRenderingAgent.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/NavigatorContentUtilsClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/NavigatorContentUtilsClientImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/NotificationPermissionClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/NotificationPermissionClientImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/PopupMenuImpl.cpp View 1 2 3 6 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameClientImpl.cpp View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/RemoteFrameOwner.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp View 1 2 3 4 9 chunks +18 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/web/StorageQuotaClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/TextFinder.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/TextFinder.cpp View 1 2 3 4 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDOMEvent.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDOMMediaStreamTrack.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDOMMessageEvent.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDataSourceImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebDataSourceImpl.cpp View 1 2 3 2 chunks +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 4 5 chunks +29 lines, -33 lines 0 comments Download
M third_party/WebKit/Source/web/WebDocument.cpp View 1 2 3 3 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebElementCollection.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebElementTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormControlElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFormElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrame.cpp View 1 2 3 3 chunks +2 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebGeolocationController.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebHistoryItem.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebHitTestResult.cpp View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebLabelElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 5 6 16 chunks +24 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/web/WebMetaElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebNode.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/WebOptionElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPepperSocketImpl.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPerformance.cpp View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebPluginContainerImpl.cpp View 1 2 3 4 5 3 chunks +2 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebPluginDocument.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebRange.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 1 2 3 4 5 6 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/WebSearchableFormData.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebSelectElement.cpp View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebSharedWorkerImpl.cpp View 1 2 3 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebSurroundingText.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebTextCheckingCompletionImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 3 4 11 chunks +17 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/web/WorkerContentSettingsClient.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WorkerContentSettingsClient.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WorkerGlobalScopeProxyProviderImpl.cpp View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/KeyboardTest.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/LinkSelectionTest.cpp View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TextFinderTest.cpp View 1 2 3 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TopControlsTest.cpp View 1 2 3 4 4 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/tests/TouchActionTest.cpp View 1 2 3 4 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebFrameTest.cpp View 1 2 3 4 5 6 17 chunks +19 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp View 1 2 3 17 chunks +37 lines, -37 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 1 2 3 4 7 chunks +13 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebViewTest.cpp View 1 2 3 4 5 6 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/public/web/WebDOMEvent.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebDOMMediaStreamTrack.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebDOMMessageEvent.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/public/web/WebDocument.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebElementCollection.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebFormControlElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebFormElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebHistoryItem.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebInputElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebLabelElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebMetaElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebNode.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebOptionElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebPerformance.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebPluginDocument.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebRange.h View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/web/WebSelectElement.h View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865813002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865813002/40001
4 years, 8 months ago (2016-04-06 06:46:47 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/14713) ios_rel_device_ninja on ...
4 years, 8 months ago (2016-04-06 06:49:29 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865813002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865813002/60001
4 years, 8 months ago (2016-04-06 08:26:41 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-06 09:34:34 UTC) #8
keishi
PTAL
4 years, 8 months ago (2016-04-06 09:37:04 UTC) #10
haraken
LGTM
4 years, 8 months ago (2016-04-06 09:38:15 UTC) #11
keishi
+dcheng Could you review the public/ files? Thanks.
4 years, 8 months ago (2016-04-06 10:35:51 UTC) #13
keishi
Ping dcheng, PTAL
4 years, 8 months ago (2016-04-07 11:35:08 UTC) #14
dcheng
lgtm
4 years, 8 months ago (2016-04-07 16:14:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865813002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865813002/80001
4 years, 8 months ago (2016-04-08 04:44:59 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/47524) linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
4 years, 8 months ago (2016-04-08 04:48:32 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865813002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865813002/100001
4 years, 8 months ago (2016-04-08 06:59:38 UTC) #23
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/web/WebLocalFrameImpl.cpp: While running git apply --index -3 -p1; error: patch ...
4 years, 8 months ago (2016-04-08 08:46:04 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865813002/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865813002/120001
4 years, 8 months ago (2016-04-08 11:46:41 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 8 months ago (2016-04-08 15:04:03 UTC) #30
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 15:05:12 UTC) #32
Message was sent while issue was closed.
Patchset 7 (id:??) landed as
https://crrev.com/36eee5a33fff7b046946db6d0f8f80a60f3e2057
Cr-Commit-Position: refs/heads/master@{#386075}

Powered by Google App Engine
This is Rietveld 408576698