Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(984)

Issue 1865803007: relnote: Add QUIC connection option DHDT to disable HPACK dynamic table. Guarded by FLAGS (Closed)

Created:
4 years, 8 months ago by Zhongyi Shi
Modified:
4 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Buck
Base URL:
https://chromium.googlesource.com/chromium/src.git@02_CL_118983961
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

relnote: Add QUIC connection option DHDT to disable HPACK dynamic table. Guarded by FLAGS_quic_disable_hpack_dynamic_table. Will be used in a Finch trial to gather data about HPACK compression efficiency: how much of HPACK's efficiency derives from the dynamic table, as opposed to other parts of HPACK such as the static table and huffman coding? If it is very low then next step would be to: o with dynamic table disabled, disable the monolithic header stream, to gather data about whether reducing HOL improves other metrics. o if results are positive, it has the advantage of maintaining (restricted) conformance to the HPACK spec. Otherwise, some (non-complient) extensions or modifications to HPACK might be necessary to reduce eliminate headers HOL blocking. o one idea involve maintining a small number of separate HPACK contexts, to ensure that dynamic reference only occur to older entries that are free of HOL blocking potential. Merge internal change: 118999202 BUG=

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -46 lines) Patch
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_flags.cc View 1 chunk +4 lines, -0 lines 1 comment Download
M net/quic/quic_headers_stream.h View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/quic_headers_stream.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_session.h View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_spdy_session.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 4 chunks +56 lines, -46 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 5 (3 generated)
Zhongyi Shi
4 years, 8 months ago (2016-04-08 05:13:58 UTC) #3
ramant (doing other things)
4 years, 8 months ago (2016-04-11 18:17:49 UTC) #5
lgtm

https://codereview.chromium.org/1865803007/diff/1/net/quic/quic_flags.cc
File net/quic/quic_flags.cc (right):

https://codereview.chromium.org/1865803007/diff/1/net/quic/quic_flags.cc#newc...
net/quic/quic_flags.cc:43: // HPACK\'s dynamic table.
nit: Why back slash?

https://codereview.chromium.org/1865803007/diff/1/net/tools/quic/end_to_end_t...
File net/tools/quic/end_to_end_test.cc (right):

https://codereview.chromium.org/1865803007/diff/1/net/tools/quic/end_to_end_t...
net/tools/quic/end_to_end_test.cc:196: // Run version negotiation tests tests
with no options, or all
overly nit: should "tests tests" be "tests"?

Powered by Google App Engine
This is Rietveld 408576698