Add support for switching library from the chrome devtools console.

Add support for switching library from the chrome devtools console.

BUG=
R=alanknight@google.com

Committed: https://github.com/dart-lang/sdk/commit/1536c671f525f3de65fff0aacfce90e5cacf6cd5

[Jacob, 2016-04-06 19:50:29]

jacobr@google.com changed reviewers:
+ alanknight@google.com

[Jacob, 2016-04-06 19:50:29]

Add support for switching library from the chrome devtools console. This allows
dartium to stop publishing each library as its own isolated context for the
devtools.

The first diff is the actual change. Review that diff but don't comment on style
nits.  The second diff is purely the result of running dartfmt.

The matching dartium CL will follow.

[Alan Knight, 2016-04-06 20:07:28]

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:57: _libraryUris[uri.toString()] =
uri;
What happens if multiple libraries have the same simple name (e.g. unnamed)?

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:81: for (var map in _fastPaths) {
In the spirit of heuristics for what the user wants, would it be worth making
this check case-insensitive?

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:146: window.console.warn("Ambiguous
library name.");
Say what the ambiguous name is?

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:536: * Handle special console
commands such as $lib and $libs that should not be
It says $lib here, but library below. Or are these two different things and I'm
not understanding?

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:545: var setLibraryCommand =
r'library ';
Why the r'?

[Jacob, 2016-04-07 00:09:26]

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
File tools/dom/src/native_DOMImplementation.dart (right):

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:57: _libraryUris[uri.toString()] =
uri;
On 2016/04/06 20:07:27, Alan Knight wrote:
> What happens if multiple libraries have the same simple name (e.g. unnamed)?
cleaned this code up. Now that case is properly handled like other ambiguous
cases... We will return back the list of matches.

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:81: for (var map in _fastPaths) {
On 2016/04/06 20:07:28, Alan Knight wrote:
> In the spirit of heuristics for what the user wants, would it be worth making
> this check case-insensitive?
Done. Added a case insensitive check as a final fallback heuristic and also
updated match highlighting to be case insensitive. Expect case won't matter much
as typically all these names are lower case.

https://codereview.chromium.org/1865803004/diff/20001/tools/dom/src/native_DO...
tools/dom/src/native_DOMImplementation.dart:146: window.console.warn("Ambiguous
library name.");
On 2016/04/06 20:07:27, Alan Knight wrote:
> Say what the ambiguous name is?

Done.

[Alan Knight, 2016-04-07 16:41:45]

lgtm

[Jacob, 2016-04-07 18:14:51]

Description was changed from

==========
Add support for switching library from the chrome devtools console.

BUG=
==========

to

==========
Add support for switching library from the chrome devtools console.

BUG=
R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1536c671f525f3de65fff0aacfce90e5cacf6cd5
==========

[Jacob, 2016-04-07 18:14:54]

Committed patchset #3 (id:40001) manually as
1536c671f525f3de65fff0aacfce90e5cacf6cd5 (presubmit successful).