tests/corelib/int_from_environment_default_value_test.dart - Issue 186573002: Revert "Fix fromEnvironment when called from isolates."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/corelib/int_from_environment_default_value_test.dart

Issue 186573002: Revert "Fix fromEnvironment when called from isolates." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/corelib/bool_from_environment_default_value_test.dart ('k') | tests/corelib/string_from_environment_default_value.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/corelib/int_from_environment_default_value_test.dart

diff --git a/tests/corelib/int_from_environment_default_value_test.dart b/tests/corelib/int_from_environment_default_value_test.dart

index 4a04e74ffa7a9d57738c0aaee35061b190678d13..d97145a6e6eef689e574a56abe910c4536d33313 100644

--- a/tests/corelib/int_from_environment_default_value_test.dart

+++ b/tests/corelib/int_from_environment_default_value_test.dart

@@ -2,20 +2,10 @@

// BSD-style license that can be found in the LICENSE file.

-import "dart:isolate";

import "package:expect/expect.dart";

-void test(port) {

+main() {

Expect.isNull(const int.fromEnvironment('NOT_FOUND'));

Expect.equals(12345, const int.fromEnvironment('NOT_FOUND',

defaultValue: 12345));

- if (port != null) port.send(null);

-main() {

- test(null);

- var port = new ReceivePort();

- Isolate.spawn(test, port.sendPort);

- port.listen((_) => port.close());

}