Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1992)

Unified Diff: runtime/lib/string.cc

Issue 186573002: Revert "Fix fromEnvironment when called from isolates." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/integers.cc ('k') | tests/corelib/bool_from_environment_default_value_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/string.cc
diff --git a/runtime/lib/string.cc b/runtime/lib/string.cc
index 96a557414917ed9e449df54f8c46c239600b8276..47a82ed60692bcb932bf92dfc39d335b6720b5a3 100644
--- a/runtime/lib/string.cc
+++ b/runtime/lib/string.cc
@@ -19,7 +19,6 @@ DEFINE_NATIVE_ENTRY(String_fromEnvironment, 3) {
GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(1));
GET_NATIVE_ARGUMENT(String, default_value, arguments->NativeArgAt(2));
// Call the embedder to supply us with the environment.
- Dart_EnterScope();
Dart_EnvironmentCallback callback = isolate->environment_callback();
if (callback != NULL) {
Dart_Handle result = callback(Api::NewHandle(isolate, name.raw()));
@@ -38,7 +37,6 @@ DEFINE_NATIVE_ENTRY(String_fromEnvironment, 3) {
String::Handle(String::New("Illegal environment value")));
}
}
- Dart_ExitScope();
return default_value.raw();
}
« no previous file with comments | « runtime/lib/integers.cc ('k') | tests/corelib/bool_from_environment_default_value_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698