Issue 18657: Support domain=IPADDR if it matches the url ip address exactly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18657: Support domain=IPADDR if it matches the url ip address exactly. (Closed)

Created:
11 years, 11 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
lcamtuf, darin (slow to review), Peter Kasting

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Support domain=IPADDR if it matches the url ip address exactly. This doesn't do anything special to handle ipv6, dotless ip address, etc. BUG=3699

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -2 lines)			Patch
	M	net/base/cookie_monster.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
	M	net/base/cookie_monster_unittest.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Dean McNamee

Whenever I touch the cookie code, I always get this feeling I'm making some stupid ...

11 years, 11 months ago (2009-01-22 11:50:16 UTC) #1

LGTM