Issue 1865663002: Let MojoSetDataPipeConsumerOptions() take null options.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1865663002: Let MojoSetDataPipeConsumerOptions() take null options. (Closed)

Created:
4 years, 8 months ago by viettrungluu

Modified:
4 years, 8 months ago

Reviewers:
vardhan

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Let MojoSetDataPipeConsumerOptions() take null options. The header defining it says that doing so means reset back to the default options. I forgot about this when implementing it. Oops. :-/ R=vardhan@google.com BUG=#442 Committed: https://chromium.googlesource.com/external/mojo/+/833e71a438e83bd654b9e71af1676a2be93459fc

Patch Set 1 #

Created: 4 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -12 lines)			Patch
M	mojo/edk/system/core_unittest.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	mojo/edk/system/data_pipe_consumer_dispatcher.cc	View	1 chunk	+13 lines, -8 lines	0 comments	Download
M	mojo/public/c/system/tests/core_unittest.cc	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

viettrungluu

4 years, 8 months ago (2016-04-05 21:17:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
833e71a438e83bd654b9e71af1676a2be93459fc (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages