WebRTC: Add recipe to build iOS API Framework

scripts/slave/recipes/webrtc/ios_api_framework.py

+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+DEPS = [
+  'archive',
+  'depot_tools/bot_update',
+  'depot_tools/gclient',
+  'file',
+  'gsutil',
+  'ios',
+  'recipe_engine/path',
+  'recipe_engine/properties',
+  'recipe_engine/step',
+  'webrtc',
+  'zip',
+]
+
+
+def RunSteps(api):
+  api.gclient.set_config('webrtc_ios')
+
+  api.ios.host_info()
+  api.bot_update.ensure_checkout()
+
+  # Clobber all out dirs to be sure to get a clean build.
+  for out_dir in ["out_ios_arm",
+                  "out_ios_arm64",
+                  "out_ios_framework",
+                  "out_ios_ia32",
+                  "out_ios_libs",
+                  "out_ios_x86_64"]:
+    api.file.rmtree('clobber %s' % out_dir, api.path['checkout'].join(out_dir))

[Michael Achenbach, 2016/04/08 12:17:49]

I'm ok with this, but it would be nicer if we had a script that took a bunch of
dirs on the cmd line to only have one step.

[kjellander_chromium, 2016/04/08 14:27:08]

Yeah, but I didn't find a supported way to do that. I'm fine with these multiple
steps for now.

+
+  build_script = api.path['checkout'].join('webrtc', 'build', 'ios',
+                                           'build_ios_framework.sh')
+  api.step('build', ['/bin/bash', build_script])

[Michael Achenbach, 2016/04/08 12:17:49]

I think you could drop the '/bin/bash' - the script might need to have
executable perms.

[kjellander_chromium, 2016/04/08 14:27:09]

Good point, that's cleaner (and yes: it has +x).

+
+  output_dir = api.path['checkout'].join('out_ios_framework')
+  zip_out = api.path['slave_build'].join('webrtc_ios_api_framework.zip')
+  api.zip.directory('zip', output_dir, zip_out)
+
+  api.gsutil.upload(
+      zip_out,
+      'chromium-webrtc',
+      'ios_api_framework/webrtc_ios_api_framework.zip',

[Michael Achenbach, 2016/04/08 12:17:50]

You continuously overwrite the same file on GS. Is that intended? Or should it
have e.g. the git hash as part of the name?

[kjellander_chromium, 2016/04/08 14:27:09]

Good catch, didn't put much thought into this obviously. Moved back to using one
of the generating functions instead.

+      args=['-a', 'public-read'],
+      unauthenticated_url=True)
+
+
+def GenTests(api):
+  yield (
+    api.test('build_ok') +
+    api.properties.generic(mastername='client.webrtc.fyi',
+                           buildername='iOS API Framework Builder',
+                           slavename='slavename')

[Michael Achenbach, 2016/04/08 12:17:49]

I think slavename has already some default when using "generic". You could
probably drop it.

[kjellander_chromium, 2016/04/08 14:27:09]

Done.

+  )
+
+  yield (
+    api.test('build_failure') +
+    api.properties.generic(mastername='client.webrtc.fyi',
+                           buildername='iOS API Framework Builder',
+                           slavename='slavename') +
+    api.step_data('build', retcode=1)
+  )