Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html

Issue 1865613002: bluetooth: Move read value to mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-separate-tests-notifications
Patch Set: Address jyasskin's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html b/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
index 75fe8c9d5aa9a9ed33997e1c098b8621515393a6..93243fd97755d0384288cc3a0150d446135f36d9 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/characteristicvaluechanged.html
@@ -7,14 +7,6 @@
test(t => { assert_true(window.testRunner instanceof Object); t.done(); },
'window.testRunner is required for the following tests.');
-// WebBluetoothServiceImpl is in charge of sending characteristicvaluechanged
-// events. WebBluetoothServiceImpl is lazily initialized so without a
-// call to startNotifications, stopNotifications, or writeValue, there will
-// be no events sent to the renderer. This will get solved once we move
-// readValue over to mojo.
-// TODO(ortuno): Re-enable once we readValue to mojo.
-// http://crbug.com/508771
-if (false) {
promise_test(() => {
return setBluetoothFakeAdapter('HeartRateAdapter')
.then(() => requestDeviceWithKeyDown({
@@ -63,5 +55,4 @@ promise_test(() => {
}
});
}, 'Add multiple event listeners then readValue().');
-}
</script>

Powered by Google App Engine
This is Rietveld 408576698