Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1865603002: ozone: Don't take a self reference in surfaceless adapter dtor (Closed)

Created:
4 years, 8 months ago by spang
Modified:
4 years, 8 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ozone: Don't take a self reference in surfaceless adapter dtor It's not valid to take a scoped_refptr to yourself inside your destructor because this in a illegal 0-1 refcount transition. This is causing our demo app to crash. Fix it by not taking a reference to the current surface if the current surface is |this|. Committed: https://crrev.com/85db89760dc91139d87886ef9ca0d94010811085 Cr-Commit-Position: refs/heads/master@{#385280}

Patch Set 1 #

Patch Set 2 : be extra paranoid about IsCurrent() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M ui/gl/gl_surface_ozone.cc View 1 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
spang
4 years, 8 months ago (2016-04-05 19:52:10 UTC) #2
dnicoara
lgtm
4 years, 8 months ago (2016-04-05 19:53:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865603002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865603002/20001
4 years, 8 months ago (2016-04-05 20:06:21 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 20:47:44 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 20:48:52 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85db89760dc91139d87886ef9ca0d94010811085
Cr-Commit-Position: refs/heads/master@{#385280}

Powered by Google App Engine
This is Rietveld 408576698