third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp - Issue 1865583002: Implement BaseAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp

Issue 1865583002: Implement BaseAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webaudio/AudioNode.idl ('K') | « third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNode.cpp ('k') | third_party/WebKit/Source/modules/webaudio/GainNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp

diff --git a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp

index 67bd8b740608542b1ec7144d792c369202400f39..ada4d3d3788182752dc1d55be1b98fe86112cbc8 100644

--- a/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp

+++ b/third_party/WebKit/Source/modules/webaudio/DynamicsCompressorNodeTest.cpp

@@ -4,7 +4,7 @@

#include "modules/webaudio/DynamicsCompressorNode.h"

#include "core/testing/DummyPageHolder.h"

-#include "modules/webaudio/AbstractAudioContext.h"

+#include "modules/webaudio/BaseAudioContext.h"

#include "modules/webaudio/OfflineAudioContext.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -17,7 +17,7 @@ TEST(DynamicsCompressorNodeTest, ProcessorLifetime)

DynamicsCompressorNode* node = context->createDynamicsCompressor(ASSERT_NO_EXCEPTION);

DynamicsCompressorHandler& handler = node->dynamicsCompressorHandler();

EXPECT_TRUE(handler.m_dynamicsCompressor);

- AbstractAudioContext::AutoLocker locker(context);

+ BaseAudioContext::AutoLocker locker(context);

handler.dispose();

// m_dynamicsCompressor should live after dispose() because an audio thread

// is using it.