third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html - Issue 1865583002: Implement BaseAudioContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html

Issue 1865583002: Implement BaseAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/webaudio/audioparam-nominal-range.html ('K') | « third_party/WebKit/LayoutTests/webaudio/mediaelementaudiosourcenode-wrapper.html ('k') | third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt » ('j') | third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html

diff --git a/third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html b/third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html

index ff191936c348420a0cebbbe4677f0949e35c51cc..71d0f9df49d5a3205afe3af0ffb34ec11385beb5 100644

--- a/third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html

+++ b/third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html

@@ -6,7 +6,7 @@

description("Check that interfaces inherit from EventTarget");

-eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort', 'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker', 'AudioContext'];

+eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort', 'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];

hongchan 2016/09/01 20:39:44 We don't check BaseAudioContext because it cannot

Raymond Toy 2016/09/01 20:51:37 Yes, I think so; BaseAudioContext can't be constru

hongchan 2016/09/01 23:03:19 If so, shouldn't we still have AudioContext and Of

for (var i = 0; i < eventTargets.length; i++) {

if (eventTargets[i] in window)