third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html - Issue 1865583002: Implement BaseAudioContext

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html

Issue 1865583002: Implement BaseAudioContext (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert change to mediaelementaudiosourcenode-gc.html Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/mediaelementaudiosourcenode-wrapper.html ('k') | third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt » ('j') | third_party/WebKit/Source/modules/webaudio/BaseAudioContext.idl » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../resources/js-test.js"></script>	3 <script src="../resources/js-test.js"></script>

4 </head>	4 </head>

5 <body>	5 <body>

6 <script>	6 <script>

7 description("Check that interfaces inherit from EventTarget");	7 description("Check that interfaces inherit from EventTarget");

8	8

9 eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort', 'Node ', 'Performance', 'SharedWorker', 'WebSocket', 'Worker', 'AudioContext'];	9 eventTargets = ['EventSource', 'FileReader', 'MediaSource', 'MessagePort',
tkent 2016/09/06 23:14:33 Don't you test BaseAudioContext? Don't you test BaseAudioContext? Raymond Toy 2016/09/07 15:44:21 I believe this doesn't matter. BaseAudioContext i Show quoted text On 2016/09/06 23:14:33, tkent wrote: > Don't you test BaseAudioContext? I believe this doesn't matter. BaseAudioContext isn't constructable so window.BaseAudioContext doesn't exist. (Which is what the test is looking for before testing.)
	10 'Node', 'Performance', 'SharedWorker', 'WebSocket', 'Worker'];
	tkent 2016/09/06 23:14:33 Add indentation. Add indentation. Raymond Toy 2016/09/07 15:51:49 Done. Show quoted text On 2016/09/06 23:14:33, tkent wrote: > Add indentation. Done.
10	11

11 for (var i = 0; i < eventTargets.length; i++) {	12 for (var i = 0; i < eventTargets.length; i++) {

12 if (eventTargets[i] in window)	13 if (eventTargets[i] in window)

13 shouldBe(eventTargets[i] + ".prototype.__proto__", "EventTarget.prototyp e");	14 shouldBe(eventTargets[i] + ".prototype.__proto__", "EventTarget.prototyp e");

14 }	15 }

15 shouldBe("Window.prototype.__proto__.__proto__", "EventTarget.prototype");	16 shouldBe("Window.prototype.__proto__.__proto__", "EventTarget.prototype");

16	17

17 </script>	18 </script>

18 </body>	19 </body>

19 </html>	20 </html>

OLD	NEW