Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1865553005: Clean up input handling in VulkanViewer (Closed)

Created:
4 years, 8 months ago by jvanverth1
Modified:
4 years, 8 months ago
Reviewers:
egdaniel, djsollen, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Clean up input handling in VulkanViewer Sets up proper handling of characters and keycodes, and event modifiers. GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1865553005 Committed: https://skia.googlesource.com/skia/+/9fab59d3a6f652e25aace376acc4e54c1ba1ce4a

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename resize params #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -257 lines) Patch
M tools/vulkan/VulkanTestContext.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tools/vulkan/VulkanTestContext.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/vulkan/Window.h View 1 3 chunks +71 lines, -3 lines 0 comments Download
M tools/vulkan/Window.cpp View 1 3 chunks +24 lines, -5 lines 0 comments Download
D tools/vulkan/viewer/InputHandler.h View 1 chunk +0 lines, -84 lines 0 comments Download
D tools/vulkan/viewer/InputHandler.cpp View 1 chunk +0 lines, -48 lines 0 comments Download
M tools/vulkan/viewer/VulkanViewer.h View 2 chunks +1 line, -4 lines 0 comments Download
M tools/vulkan/viewer/VulkanViewer.cpp View 4 chunks +8 lines, -28 lines 0 comments Download
M tools/vulkan/win/Window_win.h View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/vulkan/win/Window_win.cpp View 4 chunks +145 lines, -74 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
jvanverth1
4 years, 8 months ago (2016-04-06 17:28:25 UTC) #3
jvanverth1
Adding bsalomon@
4 years, 8 months ago (2016-04-06 17:30:21 UTC) #5
bsalomon
lgtm https://codereview.chromium.org/1865553005/diff/1/tools/vulkan/VulkanTestContext.h File tools/vulkan/VulkanTestContext.h (right): https://codereview.chromium.org/1865553005/diff/1/tools/vulkan/VulkanTestContext.h#newcode45 tools/vulkan/VulkanTestContext.h:45: void resize(int x, int y) { w, h?
4 years, 8 months ago (2016-04-06 18:06:48 UTC) #6
jvanverth1
On 2016/04/06 18:06:48, bsalomon wrote: > lgtm > > https://codereview.chromium.org/1865553005/diff/1/tools/vulkan/VulkanTestContext.h > File tools/vulkan/VulkanTestContext.h (right): > ...
4 years, 8 months ago (2016-04-06 18:22:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865553005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865553005/20001
4 years, 8 months ago (2016-04-06 18:22:58 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 19:08:54 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9fab59d3a6f652e25aace376acc4e54c1ba1ce4a

Powered by Google App Engine
This is Rietveld 408576698