Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 186553002: TimelineFlameChart: process new records incrementally. (Closed)

Created:
6 years, 9 months ago by loislo
Modified:
6 years, 9 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

TimelineFlameChart: process new records incrementally. BUG= R=pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168387

Patch Set 1 #

Patch Set 2 : unnecessary change was removed #

Patch Set 3 : _invalidate function eliminated #

Patch Set 4 : test was fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M Source/devtools/front_end/TimelineFlameChart.js View 1 2 3 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
loislo
6 years, 9 months ago (2014-03-04 11:17:29 UTC) #1
pfeldman
lgtm
6 years, 9 months ago (2014-03-04 11:47:41 UTC) #2
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 9 months ago (2014-03-04 12:28:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/186553002/50001
6 years, 9 months ago (2014-03-04 12:28:29 UTC) #4
loislo
6 years, 9 months ago (2014-03-04 14:36:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 manually as r168387 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698