Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9252)

Unified Diff: autoroll/go/repo_manager/repo_manager.go

Issue 1865503002: Fix AutoRoll+Bugdroid (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: autoroll/go/repo_manager/repo_manager.go
diff --git a/autoroll/go/repo_manager/repo_manager.go b/autoroll/go/repo_manager/repo_manager.go
index 1451591a69c92f7f0ffcb7a0bb5d66a9c27a3b2f..060853e34de0225ebb45c81b1c382b95929e7f2d 100644
--- a/autoroll/go/repo_manager/repo_manager.go
+++ b/autoroll/go/repo_manager/repo_manager.go
@@ -10,6 +10,8 @@ import (
"sync"
"time"
+ "github.com/skia-dev/glog"
+
"go.skia.org/infra/go/autoroll"
"go.skia.org/infra/go/exec"
"go.skia.org/infra/go/gitinfo"
@@ -305,14 +307,15 @@ func (r *repoManager) CreateNewRoll(emails []string, cqExtraTrybots string, dryR
}
args := []string{r.childPath, r.childHead}
- for _, bug := range bugs {
- args = append(args, "--bug", bug)
+ if len(bugs) > 0 {
+ args = append(args, "--bug", strings.Join(bugs, ","))
}
+ glog.Infof("Running command: roll-dep %s", strings.Join(args, " "))
if _, err := exec.RunCommand(&exec.Command{
Dir: r.chromiumDir,
Env: []string{fmt.Sprintf("PATH=%s:%s", r.depot_tools, os.Getenv("PATH"))},
Name: r.rollDep,
- Args: []string{r.childPath, r.childHead},
+ Args: args,
}); err != nil {
return 0, err
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698