Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1865493002:
Add ssl_error's dependency to network_time in gyp (Closed)
|
Created:
4 years, 8 months ago by hugoh_UTC2 Modified:
4 years, 8 months ago Reviewers:
estark CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd ssl_error's dependency to network_time in gyp
https://codereview.chromium.org/1772143002 updated
BUILD.gn but not the corresponding ssl_errors.gypi.
Without this fix gyp-builds get undefinded references
to NetworkTimeTracker::GetNetworkTime() when linking.
BUG=589700
Committed: https://crrev.com/1ec1d4f00849175d28aaa8694d0e82ec391dbf21
Cr-Commit-Position: refs/heads/master@{#386025}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Fixed estark's comment #
Messages
Total messages: 26 (11 generated)
hugoh@opera.com changed reviewers: + estark@chromium.org
estark, could you PTAL at this trivial fix?
https://codereview.chromium.org/1865493002/diff/1/components/ssl_errors.gypi File components/ssl_errors.gypi (right): https://codereview.chromium.org/1865493002/diff/1/components/ssl_errors.gypi#... components/ssl_errors.gypi:17: 'network_time', Please put it on the line above so that it stays in alphabetical order.
https://codereview.chromium.org/1865493002/diff/1/components/ssl_errors.gypi File components/ssl_errors.gypi (right): https://codereview.chromium.org/1865493002/diff/1/components/ssl_errors.gypi#... components/ssl_errors.gypi:17: 'network_time', On 2016/04/05 17:04:06, estark wrote: > Please put it on the line above so that it stays in alphabetical order. Done.
LGTM, thanks!
The CQ bit was checked by hugoh@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
The author hugoh@opera.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by hugoh@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hugoh@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hugoh@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865493002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hugoh@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865493002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865493002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Add ssl_error's dependency to network_time in gyp https://codereview.chromium.org/1772143002 updated BUILD.gn but not the corresponding ssl_errors.gypi. Without this fix gyp-builds get undefinded references to NetworkTimeTracker::GetNetworkTime() when linking. BUG=589700 ========== to ========== Add ssl_error's dependency to network_time in gyp https://codereview.chromium.org/1772143002 updated BUILD.gn but not the corresponding ssl_errors.gypi. Without this fix gyp-builds get undefinded references to NetworkTimeTracker::GetNetworkTime() when linking. BUG=589700 Committed: https://crrev.com/1ec1d4f00849175d28aaa8694d0e82ec391dbf21 Cr-Commit-Position: refs/heads/master@{#386025} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1ec1d4f00849175d28aaa8694d0e82ec391dbf21 Cr-Commit-Position: refs/heads/master@{#386025} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
