[Mac/GN] Initial framework bundle support.

[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=297668
Committed: https://crrev.com/80fb939caf1967692381310a634279650508718e
Cr-Commit-Position: refs/heads/master@{#385879}

[Robert Sesek, 2016-04-05 16:47:15]

Description was changed from

==========
[Mac/GN] Initial .framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=599326
==========

to

==========
[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=599326
==========

[Robert Sesek, 2016-04-05 16:47:24]

rsesek@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-04-05 22:59:49]

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni#...
build/config/mac/rules.gni:214: template("mac_framework") {
Can you document the supported parameters, in particular the ones that are
uncommon?

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni#...
build/config/mac/rules.gni:252:
"$root_out_dir/lib$_shared_library_target.dylib",
Should use "${shlib_extension}" (from build/toolchain/toolchain.gni) instead of
".dylib".
Should use "${shlib_prefix}" (from the same file) instead of "lib" prefix.

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni#...
build/config/mac/rules.gni:264: # TODO(rsesek): Process Info.plist variables.
Can you use what exists for iOS?

https://codereview.chromium.org/1865483002/diff/1/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/1865483002/diff/1/ui/base/BUILD.gn#newcode896
ui/base/BUILD.gn:896: ":ui_unittests Framework",
nit: it looks weird to have space in target labels...

[Robert Sesek, 2016-04-06 18:40:04]

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni#...
build/config/mac/rules.gni:214: template("mac_framework") {
On 2016/04/05 22:59:48, sdefresne wrote:
> Can you document the supported parameters, in particular the ones that are
> uncommon?

Done.

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni#...
build/config/mac/rules.gni:252:
"$root_out_dir/lib$_shared_library_target.dylib",
On 2016/04/05 22:59:48, sdefresne wrote:
> Should use "${shlib_extension}" (from build/toolchain/toolchain.gni) instead
of
> ".dylib".
> Should use "${shlib_prefix}" (from the same file) instead of "lib" prefix.

Done.

https://codereview.chromium.org/1865483002/diff/1/build/config/mac/rules.gni#...
build/config/mac/rules.gni:264: # TODO(rsesek): Process Info.plist variables.
On 2016/04/05 22:59:48, sdefresne wrote:
> Can you use what exists for iOS?

We don't have the variables extracted for use yet, so not yet. I will look at
using the same thing when done.

https://codereview.chromium.org/1865483002/diff/1/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/1865483002/diff/1/ui/base/BUILD.gn#newcode896
ui/base/BUILD.gn:896: ":ui_unittests Framework",
On 2016/04/05 22:59:48, sdefresne wrote:
> nit: it looks weird to have space in target labels...

I thought this was the preference based on
https://bugs.chromium.org/p/chromium/issues/detail?id=599326#c4 ?

[sdefresne, 2016-04-07 15:20:11]

lgtm

https://codereview.chromium.org/1865483002/diff/1/ui/base/BUILD.gn
File ui/base/BUILD.gn (right):

https://codereview.chromium.org/1865483002/diff/1/ui/base/BUILD.gn#newcode896
ui/base/BUILD.gn:896: ":ui_unittests Framework",
On 2016/04/06 at 18:40:04, Robert Sesek wrote:
> On 2016/04/05 22:59:48, sdefresne wrote:
> > nit: it looks weird to have space in target labels...
> 
> I thought this was the preference based on
https://bugs.chromium.org/p/chromium/issues/detail?id=599326#c4 ?

Yes, this is the preferred way (but I still think it ugly, it was more "personal
opinion" than me asking for it to be changed).

https://codereview.chromium.org/1865483002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1865483002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:356: "visbility",
"visibility"

[Robert Sesek, 2016-04-07 17:27:00]

Description was changed from

==========
[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=599326
==========

to

==========
[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=297668
==========

[Robert Sesek, 2016-04-07 17:27:33]

rsesek@chromium.org changed reviewers:
+ brettw@chromium.org

[Robert Sesek, 2016-04-07 17:27:33]

+brettw for review

https://codereview.chromium.org/1865483002/diff/20001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1865483002/diff/20001/build/config/mac/rules....
build/config/mac/rules.gni:356: "visbility",
On 2016/04/07 15:20:10, sdefresne wrote:
> "visibility"

Done.

[brettw, 2016-04-07 20:10:30]

https://codereview.chromium.org/1865483002/diff/40001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1865483002/diff/40001/build/config/mac/rules....
build/config/mac/rules.gni:353: group(_target_name) {
Can we just use target_name for the name of the group/action above and delete
this? These extra targets make a bunch of extra stuff written (currently a whole
extra build file) so unnecessary ones should be avoided.

[brettw, 2016-04-07 20:10:39]

LGTM with previous comment addressed.

[Robert Sesek, 2016-04-07 20:50:13]

https://codereview.chromium.org/1865483002/diff/40001/build/config/mac/rules.gni
File build/config/mac/rules.gni (right):

https://codereview.chromium.org/1865483002/diff/40001/build/config/mac/rules....
build/config/mac/rules.gni:353: group(_target_name) {
On 2016/04/07 20:10:29, brettw wrote:
> Can we just use target_name for the name of the group/action above and delete
> this? These extra targets make a bunch of extra stuff written (currently a
whole
> extra build file) so unnecessary ones should be avoided.

Done.

[Robert Sesek, 2016-04-07 20:50:38]

The CQ bit was checked by rsesek@chromium.org

[Robert Sesek, 2016-04-07 20:50:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1865483002/#ps60001
(title: "Remove _package_target")

[commit-bot: I haz the power, 2016-04-07 20:52:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1865483002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1865483002/60001

[commit-bot: I haz the power, 2016-04-07 21:36:58]

Description was changed from

==========
[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=297668
==========

to

==========
[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=297668
==========

[commit-bot: I haz the power, 2016-04-07 21:36:59]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-04-07 21:39:10]

Description was changed from

==========
[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=297668
==========

to

==========
[Mac/GN] Initial framework bundle support.

Things that are incomplete:
- Processing Info.plist variables.
- Not placing the intermediate shared library output in the root_out_dir.
- Modifying the install_name of the library (or using the correct output name
  initially).
- Not forcing Info.plist into binary format.

BUG=297668

Committed: https://crrev.com/80fb939caf1967692381310a634279650508718e
Cr-Commit-Position: refs/heads/master@{#385879}
==========

[commit-bot: I haz the power, 2016-04-07 21:39:11]

Patchset 4 (id:??) landed as
https://crrev.com/80fb939caf1967692381310a634279650508718e
Cr-Commit-Position: refs/heads/master@{#385879}