Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 1865443002: S390: Fix LA overflow in return sequence (Closed)

Created:
4 years, 8 months ago by john.yan
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

S390: Fix LA overflow in return sequence In test regress-492.js, the return sequence require to adjust sp to sp + 513 * 8 bytes, which causes overflow of the displacement in LA. R=michael_dawson@ca.ibm.com,mbrandy@us.ibm.com,joransiu@ca.ibm.com BUG= Committed: https://crrev.com/34c4e27e91a1122b97be937241b5b668972c1968 Cr-Commit-Position: refs/heads/master@{#35267}

Patch Set 1 #

Total comments: 3

Patch Set 2 : should use total instead of count #

Patch Set 3 : should use AddP instead of SubP #

Patch Set 4 : get ride of r0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/s390/macro-assembler-s390.cc View 1 2 3 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
john.yan
PTAL
4 years, 8 months ago (2016-04-05 14:36:28 UTC) #1
JoranSiu
https://codereview.chromium.org/1865443002/diff/1/src/s390/macro-assembler-s390.cc File src/s390/macro-assembler-s390.cc (right): https://codereview.chromium.org/1865443002/diff/1/src/s390/macro-assembler-s390.cc#newcode159 src/s390/macro-assembler-s390.cc:159: la(sp, MemOperand(sp, count * kPointerSize)); Should we just replace ...
4 years, 8 months ago (2016-04-05 14:39:41 UTC) #2
JoranSiu
lgtm
4 years, 8 months ago (2016-04-05 14:49:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865443002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865443002/60001
4 years, 8 months ago (2016-04-05 14:51:02 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 8 months ago (2016-04-05 15:16:14 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 15:17:03 UTC) #8
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/34c4e27e91a1122b97be937241b5b668972c1968
Cr-Commit-Position: refs/heads/master@{#35267}

Powered by Google App Engine
This is Rietveld 408576698