Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(804)

Issue 186543002: Refactor lithium operand declaration a little bit. (Closed)

Created:
6 years, 9 months ago by haitao.feng
Modified:
6 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor lithium operand declaration a little bit. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19775

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -140 lines) Patch
M src/lithium.h View 1 2 4 chunks +26 lines, -120 lines 0 comments Download
M src/lithium.cc View 1 2 1 chunk +21 lines, -17 lines 0 comments Download
M src/lithium-allocator.h View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
haitao.feng
PTAL.
6 years, 9 months ago (2014-03-04 08:54:22 UTC) #1
Sven Panne
DBC: This whole macro ugliness seems to be unnecessary, can't we make things a lot ...
6 years, 9 months ago (2014-03-04 09:24:59 UTC) #2
haitao.feng
We could :) Please take another look.
6 years, 9 months ago (2014-03-04 14:48:16 UTC) #3
Toon Verwaest
lgtm
6 years, 9 months ago (2014-03-10 14:23:24 UTC) #4
haitao.feng
6 years, 9 months ago (2014-03-11 02:55:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r19775 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698