Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issue 1865403003: Revert "Add (another) argument to break git locks in gclient." (Closed)

Created:
4 years, 8 months ago by smut
Modified:
4 years, 8 months ago
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Add (another) argument to break git locks in gclient." This reverts commit 51797b1d8f24a26aa7f9c23212e06ed2b6cfc0e9. BUG=601564 TBR=iannucci,dpranke,estaab,pgervais Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=299771

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -60 lines) Patch
M gclient.py View 1 chunk +0 lines, -5 lines 0 comments Download
M gclient_scm.py View 2 chunks +0 lines, -23 lines 0 comments Download
M tests/gclient_scm_test.py View 3 chunks +0 lines, -32 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
smut
See bug for logs, but this broke gclient revert on at least one bot.
4 years, 8 months ago (2016-04-07 20:22:25 UTC) #3
smut
Committed patchset #1 (id:1) manually as 299771.
4 years, 8 months ago (2016-04-07 20:23:49 UTC) #5
iannucci
4 years, 8 months ago (2016-04-07 21:35:03 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1867843003/ by iannucci@chromium.org.

The reason for reverting is: This revert breaks /everything/.

Powered by Google App Engine
This is Rietveld 408576698