Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issue 18654: Fix bug in RegExp parser. (Closed)

Created:
11 years, 11 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

RegExp parser forgot to advance after reading \c in character class. I.e., \cM was interpreted as \ccM.

Patch Set 1 #

Patch Set 2 : Added more tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M src/parser.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/regexp.js View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Lasse Reichstein
Quick review.
11 years, 11 months ago (2009-01-22 10:17:13 UTC) #1
Mads Ager (chromium)
11 years, 11 months ago (2009-01-22 10:35:44 UTC) #2
LGTM!

Powered by Google App Engine
This is Rietveld 408576698