android_webview/tools/system_webview_shell/test/data/blink-apis/eme/eme.html - Issue 1865383002: Add EME permission test to WebViewLayoutTest

Side by Side Diff: android_webview/tools/system_webview_shell/test/data/blink-apis/eme/eme.html

Issue 1865383002: Add EME permission test to WebViewLayoutTest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/tools/system_webview_shell/apk/src/org/chromium/webview_shell/WebViewLayoutTestActivity.java ('K') | « android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java ('k') | android_webview/tools/system_webview_shell/test/data/blink-apis/eme/eme-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <script src="../../resources/js-test.js"></script>

	4 <body>

	5 <script type="text/javascript">

	6 description("Test EME permission callbacks in WebView");
	timvolodine 2016/04/13 14:51:24 permission callback testing is probably not the ma permission callback testing is probably not the main issue here, maybe just call it "Test EME callbacks in WebView" or even "Test navigator.requestMediaKeySystemAccess() API in WebView"? regarding permission one could imagine adding a eme-permission-denied.. test at some point. Yoland Yan(Google) 2016/04/26 02:03:57 Done. Show quoted text On 2016/04/13 14:51:24, timvolodine wrote: > permission callback testing is probably not the main issue here, maybe just call > it "Test EME callbacks in WebView" or even "Test > navigator.requestMediaKeySystemAccess() API in WebView"? > > regarding permission one could imagine adding a eme-permission-denied.. test at > some point. Done.
	7 window.jsTestIsAsync = true;

	8

	9 // https://w3c.github.io/encrypted-media/#requestMediaKeySystemAccess

	10 // Tries multiple configuration per key system. The configurations are in

	11 // descending order of privileges such that a supported permission-requiri ng

	12 // configuration should be attempted before a configuration that does not

	13 // require permissions.
	timvolodine 2016/04/13 14:51:24 please update the comment as it does not apply please update the comment as it does not apply Yoland Yan(Google) 2016/04/26 02:03:58 Done. Show quoted text On 2016/04/13 14:51:24, timvolodine wrote: > please update the comment as it does not apply Done.
	14

	15 // TODO(yolandyan) Look into whehther more key system need to be added

	16 var chromeKeySystem = "com.widevine.alpha"

	17

	18 var tryKeySystem = function(keySystem) {

	19 console.log("keySystem is " + keySystem);
	timvolodine 2016/04/13 14:51:24 debug instead console.log debug instead console.log Yoland Yan(Google) 2016/04/26 02:03:58 Done. Show quoted text On 2016/04/13 14:51:24, timvolodine wrote: > debug instead console.log Done.
	20 navigator.requestMediaKeySystemAccess(

	21 keySystem,

	22 [

	23 { distinctiveIdentifier: "required",

	24 persistentState: "required",

	25 label: "'distinctiveIdentifier' and 'persistentState' required"

	26 },

	27 { distinctiveIdentifier: "required",

	28 label: "'distinctiveIdentifier' required"

	29 },

	30 { persistentState: "required",

	31 label: "'persistentState' required"

	32 },

	33 { label: "empty" }

	34 ]

	35 ).then(

	36 function (mediaKeySystemAccess) {

	37 console.log("eme success");
	timvolodine 2016/04/13 14:51:24 -> debug(..) -> debug(..) timvolodine 2016/04/13 14:51:24 nit: eme -> EME nit: eme -> EME Yoland Yan(Google) 2016/04/26 02:03:57 Done. Show quoted text On 2016/04/13 14:51:24, timvolodine wrote: > nit: eme -> EME Done. Yoland Yan(Google) 2016/04/26 02:03:58 Done. Show quoted text On 2016/04/13 14:51:24, timvolodine wrote: > -> debug(..) Done.
	38 finishJSTest();

	39 },

	40 function (error) {

	41 debug("onError: code" + error.code + ", message=" + error.message);

	42 finishJSTest();

	43 }

	44 );

	45 };

	46

	47 tryKeySystem(chromeKeySystem);

	48 </script>

	49 </body>

	50 </html>

OLD	NEW