Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1865373002: MD Settings: Certificate manager, polish "no certificates" text. (Closed)

Created:
4 years, 8 months ago by dpapad
Modified:
4 years, 8 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Certificate manager, polish "no certificates" text. BUG=601245 Committed: https://crrev.com/30e32f8062badd9c17e5e8943535ce8bcb10ba54 Cr-Commit-Position: refs/heads/master@{#385799}

Patch Set 1 #

Patch Set 2 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M chrome/app/settings_strings.grdp View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_list.html View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/resources/settings/certificate_manager_page/certificate_list.js View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dpapad
After screenshot at http://imgur.com/KTY7Q5x.
4 years, 8 months ago (2016-04-07 17:07:17 UTC) #2
Dan Beam
lgtm
4 years, 8 months ago (2016-04-07 17:34:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865373002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865373002/20001
4 years, 8 months ago (2016-04-07 17:40:37 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 17:52:30 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 17:54:22 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/30e32f8062badd9c17e5e8943535ce8bcb10ba54
Cr-Commit-Position: refs/heads/master@{#385799}

Powered by Google App Engine
This is Rietveld 408576698