Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Side by Side Diff: test/mjsunit/arguments.js

Issue 1865343002: [elements] revert overzealous optimzation for fast sloppy arguments delete (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/elements.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax 28 // Flags: --allow-natives-syntax
29
Igor Sheludko 2016/04/08 07:36:15 Spurious change?
30 function argc0() { 29 function argc0() {
31 return arguments.length; 30 return arguments.length;
32 } 31 }
33 32
34 function argc1(i) { 33 function argc1(i) {
35 return arguments.length; 34 return arguments.length;
36 } 35 }
37 36
38 function argc2(i, j) { 37 function argc2(i, j) {
39 return arguments.length; 38 return arguments.length;
(...skipping 157 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 // Turn arguments into slow. 196 // Turn arguments into slow.
198 assertTrue(%HasSloppyArgumentsElements(a)); 197 assertTrue(%HasSloppyArgumentsElements(a));
199 a[10000] = 1; 198 a[10000] = 1;
200 assertTrue(%HasSloppyArgumentsElements(a)); 199 assertTrue(%HasSloppyArgumentsElements(a));
201 // Make it fast again by adding values. 200 // Make it fast again by adding values.
202 for (var i = 0; i < 1000; i++) { 201 for (var i = 0; i < 1000; i++) {
203 a[i] = 1.5; 202 a[i] = 1.5;
204 } 203 }
205 assertTrue(%HasSloppyArgumentsElements(a)); 204 assertTrue(%HasSloppyArgumentsElements(a));
206 })(); 205 })();
206
207 (function testDeleteArguments() {
208 function f() { return arguments };
209 var args = f(1, 2);
210 assertEquals(1, args[0]);
211 assertEquals(2, args[1]);
212 assertEquals(2, args.length);
213
214 delete args[0];
215 assertEquals(undefined, args[0]);
216 assertEquals(2, args[1]);
217 assertEquals(2, args.length);
218
219 delete args[1];
220 assertEquals(undefined, args[0]);
221 assertEquals(undefined, args[1]);
222 assertEquals(2, args.length);
223 })();
224
225 (function testDeleteFastSloppyArguments() {
226 function f(a) { return arguments };
227 var args = f(1, 2);
228 assertEquals(1, args[0]);
229 assertEquals(2, args[1]);
230 assertEquals(2, args.length);
231
232 delete args[0];
233 assertEquals(undefined, args[0]);
234 assertEquals(2, args[1]);
235 assertEquals(2, args.length);
236
237 delete args[1];
238 assertEquals(undefined, args[0]);
239 assertEquals(undefined, args[1]);
240 assertEquals(2, args.length);
241 })();
242
243 (function testDeleteSlowSloppyArguments() {
244 var key = 10000;
245 function f(a) {
246 arguments[key] = key;
247 return arguments
248 };
249 var args = f(1, 2);
250 assertEquals(1, args[0]);
251 assertEquals(2, args[1]);
252 assertEquals(key, args[key]);
253 assertEquals(2, args.length);
254
255 delete args[0];
256 assertEquals(undefined, args[0]);
257 assertEquals(2, args[1]);
258 assertEquals(key, args[key]);
259 assertEquals(2, args.length);
260
261 delete args[1];
262 assertEquals(undefined, args[0]);
263 assertEquals(undefined, args[1]);
264 assertEquals(key, args[key]);
265 assertEquals(2, args.length);
266
267 delete args[key];
268 assertEquals(undefined, args[0]);
269 assertEquals(undefined, args[1]);
270 assertEquals(undefined, args[key]);
271 assertEquals(2, args.length);
272 })();
OLDNEW
« no previous file with comments | « src/elements.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698