Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1865343002: [elements] revert overzealous optimzation for fast sloppy arguments delete (Closed)

Created:
4 years, 8 months ago by Camillo Bruni
Modified:
4 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] revert overzealous optimzation for fast sloppy arguments delete BUG=chromium:601390 LOG=n Committed: https://crrev.com/ad1784e5c68b14ff0400b7221ce55d1478066013 Cr-Commit-Position: refs/heads/master@{#35345}

Patch Set 1 #

Total comments: 1

Patch Set 2 : addressing comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -2 lines) Patch
M src/elements.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M test/mjsunit/arguments.js View 1 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865343002/1
4 years, 8 months ago (2016-04-07 14:52:21 UTC) #2
Camillo Bruni
PTAL, small CL :)
4 years, 8 months ago (2016-04-07 14:52:59 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/13368)
4 years, 8 months ago (2016-04-07 15:12:29 UTC) #6
Igor Sheludko
lgtm with a nit: https://codereview.chromium.org/1865343002/diff/1/test/mjsunit/arguments.js File test/mjsunit/arguments.js (left): https://codereview.chromium.org/1865343002/diff/1/test/mjsunit/arguments.js#oldcode29 test/mjsunit/arguments.js:29: Spurious change?
4 years, 8 months ago (2016-04-08 07:36:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1865343002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1865343002/20001
4 years, 8 months ago (2016-04-08 07:40:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-08 08:02:38 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-08 08:02:59 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad1784e5c68b14ff0400b7221ce55d1478066013
Cr-Commit-Position: refs/heads/master@{#35345}

Powered by Google App Engine
This is Rietveld 408576698